> On Nov. 3, 2017, 9:02 a.m., Nigel Jones wrote: > > om-fwk-gaf/src/main/java/org/apache/atlas/gaf/ffdc/README.md > > Lines 19 (patched) > > <https://reviews.apache.org/r/63502/diff/1/?file=1878779#file1878779line19> > > > > I presume this is part of the changes not ready for review? (given a) > > we've changed the name of the gaf & b) this is omas specific rather than > > belonging in core connector framework?)
As description says - the GAF frameworks is not ready for review - it is however still called the GAF :) Only the Governance Action OMAS was renamed to Governance Engine OMAS. There was no change in the name of the GAF itself. - Mandy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review190017 ----------------------------------------------------------- On Nov. 2, 2017, 12:03 p.m., Mandy Chessell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63502/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2017, 12:03 p.m.) > > > Review request for atlas, David Radley and Madhan Neethiraj. > > > Repository: atlas > > > Description > ------- > > This is a request for review of the OMRS Connector API. The files of > interest are: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/* > omrs/src/main/java/org/apache/atlas/omrs/connectors/* > omrs/src/main/java/org/apache/atlas/omrs/ffdc/* > > There is a patch connected to > https://issues.apache.org/jira/projects/ATLAS/issues/ATLAS-2246 that has the > code plus other code that is not ready for review. The OMRS Connector API > depends on the OCF - see https://issues.apache.org/jira/browse/ATLAS-1095. > > There is some OMAS code in the patch that can be ignored. > > > Diffs > ----- > > om-fwk-gaf/pom.xml PRE-CREATION > om-fwk-gaf/src/main/java/org/apache/atlas/gaf/ffdc/GAFCheckedException.java > PRE-CREATION > om-fwk-gaf/src/main/java/org/apache/atlas/gaf/ffdc/GAFErrorCode.java > PRE-CREATION > om-fwk-gaf/src/main/java/org/apache/atlas/gaf/ffdc/GAFRuntimeException.java > PRE-CREATION > om-fwk-gaf/src/main/java/org/apache/atlas/gaf/ffdc/README.md PRE-CREATION > omas-assetconsumer/README.md PRE-CREATION > omas-assetconsumer/pom.xml PRE-CREATION > > omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/AssetConsumerInterface.java > PRE-CREATION > > omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/client/AssetConsumer.java > PRE-CREATION > > omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/AssetConsumerCheckedExceptionBase.java > PRE-CREATION > > omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/AssetConsumerErrorCode.java > PRE-CREATION > > omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/AssetConsumerRuntimeException.java > PRE-CREATION > > omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/AssetNotReferenceableException.java > PRE-CREATION > > omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/ConnectionNameAmbiguousException.java > PRE-CREATION > > omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/README.md > PRE-CREATION > > omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/UnknownConnectionGUIDException.java > PRE-CREATION > > omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/ffdc/UnknownConnectionURLException.java > PRE-CREATION > > omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerREST.java > PRE-CREATION > omas-assetowner/pom.xml PRE-CREATION > > omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/ffdc/AssetOwnerErrorCode.java > PRE-CREATION > > omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/Endpoints.java > PRE-CREATION > > omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/Host.java > PRE-CREATION > > omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/Platform.java > PRE-CREATION > > omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/Server.java > PRE-CREATION > > omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/ServerCapabilities.java > PRE-CREATION > > omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/ServerCapability.java > PRE-CREATION > > omas-assetowner/src/main/java/org/apache/atlas/omas/assetowner/properties/Servers.java > PRE-CREATION > omas-connectedasset/README.md PRE-CREATION > omas-connectedasset/pom.xml PRE-CREATION > > omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/ConnectedAssetInterface.java > PRE-CREATION > > omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/client/ConnectedAsset.java > PRE-CREATION > > omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/ffdc/ConnectedAssetErrorCode.java > PRE-CREATION > > omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/ffdc/ConnectedAssetRuntimeException.java > PRE-CREATION > > omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/ffdc/README.md > PRE-CREATION > > omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/properties/OMASConnectedAssetProperties.java > PRE-CREATION > > omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/properties/OMASRelatedAsset.java > PRE-CREATION > > omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/properties/OMASRelatedAssetProperties.java > PRE-CREATION > > omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/ConnectedAssetREST.java > PRE-CREATION > omrs/README.md PRE-CREATION > omrs/pom.xml PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/connectors/OMRSConnection.java > PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/connectors/OMRSConnector.java > PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/connectors/OMRSConnectorBase.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/connectors/OMRSConnectorProviderBase.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/connectors/enterprise/EnterpriseOMRSConnector.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/connectors/enterprise/EnterpriseOMRSConnectorProvider.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/connectors/enterprise/EnterpriseOMRSMetadataCollection.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/connectors/enterprise/MetadataCollections.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/connectors/rest/OMRSRESTConnector.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/connectors/rest/OMRSRESTConnectorProvider.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/connectors/rest/OMRSRESTMetadataCollection.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/ffdc/ClassificationNotKnownException.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/ffdc/EntityNotDeletedException.java > PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/EntityNotKnownException.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/ffdc/NotImplementedRuntimeException.java > PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/OMRSCheckedExceptionBase.java > PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/OMRSErrorCode.java > PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/OMRSRuntimeException.java > PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/PagingErrorException.java > PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/PropertyErrorException.java > PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/README.md PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/ffdc/RelationshipNotDeletedException.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/ffdc/RelationshipNotKnownException.java > PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/RepositoryErrorException.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/ffdc/StatusNotSupportedException.java > PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/TypeDefInUseException.java > PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/TypeDefNotKnownException.java > PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/ffdc/TypeErrorException.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/MetadataCollection.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/MatchCriteria.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/SequencingOrder.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/ArrayPropertyValue.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Classification.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Classifications.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityDetail.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityDetails.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityProxy.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntitySummaries.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntitySummary.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntityUniverse.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EnumPropertyValue.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceElementHeader.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceGraph.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceHeader.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceIterator.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceProperties.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstancePropertyCategory.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstancePropertyValue.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceProvenanceType.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceStatus.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceTypes.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/MapPropertyValue.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/PrimitivePropertyValue.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Relationship.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Relationships.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/StructPropertyValue.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/AttributeCardinality.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/AttributeDef.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/AttributeDefs.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/AttributeTypeDef.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/ClassificationDef.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/ClassificationDefs.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/ClassificationPropagationRule.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/CollectionDef.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/CollectionDefCategory.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/CollectionDefs.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EntityDef.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EntityDefs.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EnumDef.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EnumDefs.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EnumElementDef.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EnumElementDefs.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/ExternalStandardMapping.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/ExternalStandardMappings.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/PrimitiveDef.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/PrimitiveDefCategory.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/PrimitiveDefs.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/RelationshipCategory.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/RelationshipDef.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/RelationshipDefs.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/RelationshipEndDef.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/StringIdentifiers.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/StructDef.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/StructDefs.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDef.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefCategory.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefElementHeader.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefGallery.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefProperties.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefs.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/registry/ClusterOMRSConnection.java > PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/registry/ClusterRegistry.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/registry/ClusterRegistryConfigFile.java > PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/registry/LocalRegistration.java > PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/registry/RemoteConnections.java > PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/registry/RemoteRegistration.java > PRE-CREATION > omrs/src/main/java/org/apache/atlas/omrs/registry/RemoteRegistrations.java > PRE-CREATION > > omrs/src/main/java/org/apache/atlas/omrs/registry/SynchronizationSpecification.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/63502/diff/1/ > > > Testing > ------- > > There are samples of OMRS Connectors (without the metadata collection > implementations. I will do them once I have feedback on the basic API > > > Thanks, > > Mandy Chessell > >
