-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63909/#review191366
-----------------------------------------------------------



After removal of source/target directives, "mvn package -DskipTests 
-DskipEnunciate=false" fails with the following error (i.e. doesn't recognize 
Java 1.7+ syntax). I will have a review shortly to add source/target 
directrives with 1.8 as version.

[WARNING] [ENUNCIATE] [javac] [ERROR] 
com.webcohesion.enunciate.Enunciate$URLFileObject[file:/Apache/git/atlas/webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java]:360:58
 
/Apache/git/atlas/webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java:360:
 error: diamond operator is not supported in -source 1.5
[WARNING] [ENUNCIATE] [javac] 
/Apache/git/atlas/webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java:360:
 error: diamond operator is not supported in -source 1.5
[WARNING] [ENUNCIATE] [javac]         List<AtlasClassification> ret    = new 
ArrayList<>();
[WARNING] [ENUNCIATE] [javac]                                                   
       ^
[WARNING] [ENUNCIATE] [javac]   (use -source 7 or higher to enable diamond 
operator)

- Madhan Neethiraj


On Nov. 17, 2017, 12:52 p.m., Graham Wallis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63909/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2017, 12:52 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-2232 - Remove source and target directives now at java8
> Only file affected is webapp/pom.xml
> 
> 
> Diffs
> -----
> 
>   webapp/pom.xml 569e06f8dfcbfc57d3e4a602e355f4ab0c7eea32 
> 
> 
> Diff: https://reviews.apache.org/r/63909/diff/1/
> 
> 
> Testing
> -------
> 
> Built with enunciate enabled and inspected API docs, which look fine.
> mvn clean
> mvn install -DskipTests
> mvn package -DskipTests -DskipEnunciate=false
> 
> 
> Thanks,
> 
> Graham Wallis
> 
>

Reply via email to