----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65015/ -----------------------------------------------------------
(Updated Jan. 8, 2018, 9:14 p.m.) Review request for atlas. Changes ------- Refactored to perform validation in FormatConverter implementations, to enable special handling of V1 values: enum - ordinal, entity - referenceable/id, struct - struct/map. This helps keep existing validation in AtlasType implementation to deal with only V2 values. Bugs: ATLAS-2327 https://issues.apache.org/jira/browse/ATLAS-2327 Repository: atlas Description ------- added attribute valudation to V1 to V2 conversion, which is used in V1 REST APIs. Diffs (updated) ----- repository/src/main/java/org/apache/atlas/repository/converters/AtlasAbstractFormatConverter.java ab0d1fca repository/src/main/java/org/apache/atlas/repository/converters/AtlasArrayFormatConverter.java 882cd1bd repository/src/main/java/org/apache/atlas/repository/converters/AtlasEntityFormatConverter.java 3d1d7ad1 repository/src/main/java/org/apache/atlas/repository/converters/AtlasEnumFormatConverter.java da76c5a7 repository/src/main/java/org/apache/atlas/repository/converters/AtlasFormatConverter.java a6d43dab repository/src/main/java/org/apache/atlas/repository/converters/AtlasMapFormatConverter.java bdfbf390 repository/src/main/java/org/apache/atlas/repository/converters/AtlasObjectIdConverter.java a5b6d845 repository/src/main/java/org/apache/atlas/repository/converters/AtlasStructFormatConverter.java a5c9dede Diff: https://reviews.apache.org/r/65015/diff/2/ Changes: https://reviews.apache.org/r/65015/diff/1-2/ Testing ------- verified that invalid entity attribute values in V1 REST APIs result in the same error raised by equivalent V2 REST APIs. Thanks, Madhan Neethiraj