----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65121/#review195320 -----------------------------------------------------------
webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java Lines 140 (patched) <https://reviews.apache.org/r/65121/#comment274500> This is looking good. I suggest adding more context in the error messages to make them more informative. - please include the exact config file name - please include the exact config property name in the message - so it can be searched for in the property file i.e. "atlas.authentication.method.kerberos.token.validity" - please include the invalid string value in the message - David Radley On Jan. 12, 2018, 1:12 p.m., Nixon Rodrigues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65121/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2018, 1:12 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and > Sarath Subramanian. > > > Bugs: ATLAS-2352 > https://issues.apache.org/jira/browse/ATLAS-2352 > > > Repository: atlas > > > Description > ------- > > This patch includes fix to configure validity for Kerberos DelegationToken. > > Property to be added in atlas-application.properties. > > *atlas.authentication.method.kerberos.token.validity*=3600 > > > Diffs > ----- > > docs/src/site/twiki/Authentication-Authorization.twiki 1e35ceb4 > > webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java > 1d553e03 > > > Diff: https://reviews.apache.org/r/65121/diff/2/ > > > Testing > ------- > > Kerberos delegation token expiration time is set correctly in hadoop-auth > cookie. > > > Thanks, > > Nixon Rodrigues > >
