----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65133/#review195357 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/query/AtlasDSL.java Lines 53 (patched) <https://reviews.apache.org/r/65133/#comment274522> Having 'inputQuery' as static - would this cause trouble when multiple DSL queries execute simultaneously? - Madhan Neethiraj On Jan. 12, 2018, 9:45 p.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65133/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2018, 9:45 p.m.) > > > Review request for atlas and Apoorv Naik. > > > Bugs: ATLAS-2360 > https://issues.apache.org/jira/browse/ATLAS-2360 > > > Repository: atlas > > > Description > ------- > > **Background** > The _GremlinQueryComposer.errorList_ used earlier in the implementation was > not getting populated correctly. The errors encountered in the process were > not getting displayed. > > **Approach** > The _GremlinQueryComposer.errorList_ is now being populated at different > point in the parsing process. > > _AtlasDSL_ has been updated to process the errors and throw exceptions. > > Additional refactoring in _IdentifierHelper_ when processing _qualifiedName_. > > **Queries** > The following query displays an error since 'name' is not attribute of > _hive_storagedescriptor_: > ``` > hive_table select sd.name > ``` > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 0953725c > repository/src/main/java/org/apache/atlas/query/AtlasDSL.java 7817f91a > repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java > fe2d6d7f > repository/src/main/java/org/apache/atlas/query/IdentifierHelper.java > d8221aa0 > repository/src/main/java/org/apache/atlas/query/Lookup.java fa75cfbd > repository/src/main/java/org/apache/atlas/query/RegistryBasedLookup.java > b78bd2e5 > repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java > 5db55dce > > repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java > 3fcd3256 > > > Diff: https://reviews.apache.org/r/65133/diff/1/ > > > Testing > ------- > > **Unit tests** > - New tests added for processing exceptions. > > **Functional tests** > - Verified cases where error is displayed. > > > Thanks, > > Ashutosh Mestry > >
