----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65770/#review198214 -----------------------------------------------------------
Overall it's a very good change, simplification of policies and rules has led to a much cleaner/concise code authorization/src/main/java/org/apache/atlas/authorize/AtlasEntityAttribute.java Lines 1 (patched) <https://reviews.apache.org/r/65770/#comment278324> Missing ASF header repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java Lines 97 (patched) <https://reviews.apache.org/r/65770/#comment278325> Can you pull all these error messages as separate AtlasErrorCode messages ? Please review all occurences repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java Lines 187 (patched) <https://reviews.apache.org/r/65770/#comment278326> This comment doesn't look valid in the context repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java Lines 231 (patched) <https://reviews.apache.org/r/65770/#comment278327> Can we do this authorization check even before the mapping ? webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthorizationFilter.java Line 49 (original), 37 (patched) <https://reviews.apache.org/r/65770/#comment278328> This looks pretty much no-op. Can this be removed if that's the case ? - Apoorv Naik On Feb. 23, 2018, 1:22 p.m., Nixon Rodrigues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65770/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2018, 1:22 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj. > > > Bugs: ATLAS-2459 > https://issues.apache.org/jira/browse/ATLAS-2459 > > > Repository: atlas > > > Description > ------- > > The patch contains changes for Fine grained authorization at Instance level. > Earlier implementation of authorization at API level is removed. > > https://issues.apache.org/jira/browse/ATLAS-2459 > > > Diffs > ----- > > authorization/pom.xml f210a2f8 > > authorization/src/main/java/org/apache/atlas/authorize/AtlasAccessRequest.java > 07cb2b07 > > authorization/src/main/java/org/apache/atlas/authorize/AtlasActionTypes.java > c5969db1 > authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizer.java > d64c6923 > > authorization/src/main/java/org/apache/atlas/authorize/AtlasEntityAccessRequest.java > PRE-CREATION > > authorization/src/main/java/org/apache/atlas/authorize/AtlasEntityAttribute.java > PRE-CREATION > authorization/src/main/java/org/apache/atlas/authorize/AtlasPrivilege.java > PRE-CREATION > > authorization/src/main/java/org/apache/atlas/authorize/AtlasResourceTypes.java > 7e2808cb > > authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasAuthorizationUtils.java > 5bc19414 > > authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasSimpleAuthzPolicy.java > PRE-CREATION > > authorization/src/main/java/org/apache/atlas/authorize/simple/FileReaderUtil.java > 88bf56b1 > > authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyDef.java > 6b2b8b30 > > authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyParser.java > f61bbf76 > > authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyUtil.java > 9c08e405 > > authorization/src/main/java/org/apache/atlas/authorize/simple/SimpleAtlasAuthorizer.java > 2eb0cd50 > > authorization/src/test/java/org/apache/atlas/authorize/simple/AtlasAuthorizationUtilsTest.java > adebb627 > > authorization/src/test/java/org/apache/atlas/authorize/simple/PolicyParserTest.java > 3b7869aa > > authorization/src/test/java/org/apache/atlas/authorize/simple/PolicyUtilTest.java > 1cefbcdf > > authorization/src/test/java/org/apache/atlas/authorize/simple/SimpleAtlasAuthorizerTest.java > b36c9c75 > distro/src/conf/atlas-simple-authz-policy.json PRE-CREATION > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java ff09e6c9 > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java > 340cd05c > intg/src/main/java/org/apache/atlas/utils/AtlasJson.java 4f7b716e > repository/pom.xml 87fe7fde > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java > 8214cea6 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java > 1d784ef8 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java > ca0eeeb6 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java > 83a6d1d6 > > webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthorizationFilter.java > 8a29bb3f > webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java > 86485fba > webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 7177ac74 > > > Diff: https://reviews.apache.org/r/65770/diff/1/ > > > Testing > ------- > > maven build is gone fine. > Testing of endpoints is in progress. > > > Thanks, > > Nixon Rodrigues > >
