----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65813/#review198340 -----------------------------------------------------------
addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java Lines 205 (patched) <https://reviews.apache.org/r/65813/#comment278478> This would result in invalid process entity, with: - empty 'outputs' (line #206) - empty 'inputs' (line #208) If Sqoop hook is not provided with details of the Hive table involved, I think the hook should create lineage between SqoopDataStore & HiveDatabase. addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java Lines 236 (patched) <https://reviews.apache.org/r/65813/#comment278479> add 'clusterName'. - Madhan Neethiraj On Feb. 27, 2018, 11:24 a.m., Ruchi Solani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65813/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2018, 11:24 a.m.) > > > Review request for atlas and Madhan Neethiraj. > > > Bugs: ATLAS-2462 > https://issues.apache.org/jira/browse/ATLAS-2462 > > > Repository: atlas > > > Description > ------- > > When tried importing a specific table with below command there is no error: > > sqoop import --connect jdbc:mysql://localhost/test --table testtable221 > --hive-import --hive-database sqoopimport023 --hive-table hivetesttable221 > --username root -P -m 1 --fetch-size 1 > > When tried to import all tables from a specific database using below command, > got NP error: > > sqoop import-all-tables --connect jdbc:mysql://localhost/test --hive-import > --hive-database sqoopimport022 --username root -P -m 1 --fetch-size 1 > > > Diffs > ----- > > > addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java > 06a0e9c > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 2f870dc > > > Diff: https://reviews.apache.org/r/65813/diff/2/ > > > Testing > ------- > > sanity testing done. > > > Thanks, > > Ruchi Solani > >
