-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65885/
-----------------------------------------------------------

(Updated March 20, 2018, 12:04 a.m.)


Review request for atlas and David Radley.


Changes
-------

Fixed the injection of the logback jars in the distribution, they no longer are 
being pulled in, and logging has returned to normal.

I attempted to do a full build with tests, but the tests in repository failed. 
I do not believe the failure is due to this patch, as the same exact failure 
happens in master. The cassandra based audit tests do pass even if the 
subsequent tests are failing.

As an additional test on this patch, I applied the patch to a clean master with:

git am < ATLAS=2470-4.patch

It did give some warnings on whitespace, but properly applied the patch. I then 
built and ran Atlas with embedded-cassandra-solr and it started up with no 
errors.


Bugs: ATLAS-2470
    https://issues.apache.org/jira/browse/ATLAS-2470


Repository: atlas


Description
-------

This updates pom's to add the needed cassandra jars, and adds a dist profile 
embedded-cassandra-solr.


Diffs (updated)
-----

  distro/pom.xml 0103bef6 
  distro/src/bin/atlas_config.py e6415cf4 
  distro/src/bin/atlas_start.py 39be6b7c 
  distro/src/bin/atlas_stop.py 66edd904 
  distro/src/conf/atlas-application.properties 10fb7b86 
  distro/src/conf/atlas-env.sh 68b24e93 
  distro/src/conf/cassandra.yml.template PRE-CREATION 
  distro/src/conf/zookeeper/log4j.properties PRE-CREATION 
  distro/src/conf/zookeeper/zoo.cfg.template PRE-CREATION 
  distro/src/main/assemblies/standalone-package.xml 1881082e 
  docs/src/site/twiki/InstallationSteps.twiki 6b9f0313 
  graphdb/janus/pom.xml 143b775f 
  pom.xml 9ddc8e18 
  repository/pom.xml b1d6b1f9 
  
repository/src/main/java/org/apache/atlas/repository/audit/AbstractStorageBasedAuditRepository.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/audit/CassandraBasedAuditRepository.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
 cee7374e 
  
repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java
 4d70b7f7 
  
repository/src/test/java/org/apache/atlas/repository/audit/CassandraAuditRepositoryTest.java
 PRE-CREATION 
  repository/src/test/resources/cassandra_test.yml PRE-CREATION 
  
server-api/src/main/java/org/apache/atlas/listener/ActiveStateChangeHandler.java
 7d282b30 


Diff: https://reviews.apache.org/r/65885/diff/4/

Changes: https://reviews.apache.org/r/65885/diff/3-4/


Testing
-------

Full build with the new embedded-cassandra-solr, and testing to make sure Atlas 
comes up and is functional.

Be aware that we have been running Cassandra backed JanusGraph for months with 
no issues.

This patch now includes support for Cassandra as an audit store. I've also 
refactored the audit unit tests, and added cassandra specific tests.


Thanks,

Pierre Padovani

Reply via email to