----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66252/#review199915 -----------------------------------------------------------
Fix it, then Ship it! repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java Line 252 (original), 252 (patched) <https://reviews.apache.org/r/66252/#comment280419> It might be efficient to avoid creating a dummy instance in every call. Can you please try using a static final instance, as below? private static final TypeReference<List<TimeBoundary>> TIME_BOUNDARIES_LIST_TYPE = new TypeReference<List<TimeBoundary>>() {}; ret.setValidityPeriods(AtlasJson.fromJson(strValidityPeriods, TIME_BOUNDARIES_LIST_TYPE); - Madhan Neethiraj On March 23, 2018, 9:13 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66252/ > ----------------------------------------------------------- > > (Updated March 23, 2018, 9:13 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj. > > > Bugs: ATLAS-2513 > https://issues.apache.org/jira/browse/ATLAS-2513 > > > Repository: atlas > > > Description > ------- > > When a classification is updated for the following operations: > > * Update attributes > * Add/Update validity periods > > Notification messages are not sent about the impacted entities and only > source entity information is sent in notification. > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java > 57aa41b4 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java > 38851575 > > > Diff: https://reviews.apache.org/r/66252/diff/2/ > > > Testing > ------- > > Validated operations through POSTMAN rest client and notifications are sent > about impacted entities as well. > > > Thanks, > > Sarath Subramanian > >
