----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66261/#review199921 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java Line 500 (original), 498 (patched) <https://reviews.apache.org/r/66261/#comment280431> Getting classificationNames above (line #492) would have iterated through edges named as 'classifiedAs'. The same edges are retrieved again in the 'for' loop below (like #499). Consider adding a method "List<AtlasEdge> getClassificationEdges(entityVertex)" and use the returned edges in following "for" loop. repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java Lines 693 (patched) <https://reviews.apache.org/r/66261/#comment280430> instanceVertex => classificationVertex - Madhan Neethiraj On March 23, 2018, 9:24 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66261/ > ----------------------------------------------------------- > > (Updated March 23, 2018, 9:24 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj. > > > Bugs: ATLAS-2514 > https://issues.apache.org/jira/browse/ATLAS-2514 > > > Repository: atlas > > > Description > ------- > > When a table with tag assigned is deleted, the propagated classification > edges to the downstream entities should not be removed. > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java > 18ed533d > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java > 49c9e0ca > > > Diff: https://reviews.apache.org/r/66261/diff/1/ > > > Testing > ------- > > > Thanks, > > Sarath Subramanian > >
