----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66642/#review201385 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java Lines 238 (patched) <https://reviews.apache.org/r/66642/#comment282607> getOrDefault(v, null) can return null; calling ".equals() on this will result in NPE. Please review and update. repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java Lines 299 (patched) <https://reviews.apache.org/r/66642/#comment282605> It seems '&&' isn't correct here; '||' is more appropriate. Also, note that Map.containsKey() may fail with exception for 'null' value argument. repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java Lines 303 (patched) <https://reviews.apache.org/r/66642/#comment282606> getOrDefault(v, null) can return null; calling ".equals() on this will result in NPE. Please review and update. - Madhan Neethiraj On April 17, 2018, 10:29 p.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66642/ > ----------------------------------------------------------- > > (Updated April 17, 2018, 10:29 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath > Subramanian. > > > Bugs: ATLAS-2534 > https://issues.apache.org/jira/browse/ATLAS-2534 > > > Repository: atlas > > > Description > ------- > > 1. Fixing a bug where the update of category, term causes the old relations > to be ovewritten in some cases. > 2. Duplicate Glossary, term, category creation attempt return 409 Conflict > 3. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java bbb1b1a91 > > repository/src/main/java/org/apache/atlas/glossary/GlossaryCategoryUtils.java > 46d888982 > repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java > 9fd795b91 > repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java > c2d2d2b51 > repository/src/main/java/org/apache/atlas/glossary/GlossaryUtils.java > 38555cc36 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java > 57c91356d > repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java > 029455071 > webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java f0c5d8616 > > > Diff: https://reviews.apache.org/r/66642/diff/1/ > > > Testing > ------- > > PreCommit: > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/285/console > (running) > > > Thanks, > > Apoorv Naik > >
