----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66760/#review201746 -----------------------------------------------------------
Ship it! Ship It! - Sarath Subramanian On April 23, 2018, 4:31 a.m., pratik pandey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66760/ > ----------------------------------------------------------- > > (Updated April 23, 2018, 4:31 a.m.) > > > Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and > Sarath Subramanian. > > > Bugs: ATLAS-2594 > https://issues.apache.org/jira/browse/ATLAS-2594 > > > Repository: atlas > > > Description > ------- > > For the following lineage : > > table1 ----- edge1 ----> process1 ----- edge2 -----> table2 > > Added tag1 from table1 with propagate set to True . On detailPage of table2 , > Propagated classifications list shows tag1. > > Now , on detailPage of table2 , edited edge1 and set propagateTags to > ONE_TO_TWO (process1 to table1). Relationship update is done and tag1 is > removed from process1 and table2 in the backend. > But , UI needs a refresh to remove tag1 from Propagated Classifications list > shown on detailsPage of table2 > > > Diffs > ----- > > dashboardv2/public/css/scss/override.scss c3ee8b1 > dashboardv2/public/css/scss/theme.scss 4848673 > > dashboardv2/public/js/templates/graph/PropagationPropertyModalView_tmpl.html > 1599858 > dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js eb17504 > dashboardv2/public/js/views/graph/LineageLayoutView.js c1d8a9c > dashboardv2/public/js/views/graph/PropagationPropertyModal.js 76d62ef > > > Diff: https://reviews.apache.org/r/66760/diff/1/ > > > Testing > ------- > > Done one round of sanity testing. > > > Thanks, > > pratik pandey > >
