----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66838/#review202041 -----------------------------------------------------------
Fix it, then Ship it! webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java Lines 286 (patched) <https://reviews.apache.org/r/66838/#comment283700> StringUtils.isEmpty(attrName) check is not needed here, it already done in line#278 - Sarath Subramanian On April 26, 2018, 4:42 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66838/ > ----------------------------------------------------------- > > (Updated April 26, 2018, 4:42 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, keval bhatt, and > Sarath Subramanian. > > > Bugs: ATLAS-2620 > https://issues.apache.org/jira/browse/ATLAS-2620 > > > Repository: atlas > > > Description > ------- > > Current implementation of the REST API for entity-lookup was done before > basic-search API was introduced. Updated the implementation to use > basic-search, which is more efficient. > > > Diffs > ----- > > webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java af309a175 > > > Diff: https://reviews.apache.org/r/66838/diff/1/ > > > Testing > ------- > > - validated in my local deployment > - precommit is in progress - > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/311/ > > > Thanks, > > Madhan Neethiraj > >
