----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67033/#review202862 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On May 10, 2018, 7:10 p.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67033/ > ----------------------------------------------------------- > > (Updated May 10, 2018, 7:10 p.m.) > > > Review request for atlas, Madhan Neethiraj and Sarath Subramanian. > > > Repository: atlas > > > Description > ------- > > ATLAS-2666:Add unit test to KafkaBridge > > > Diffs > ----- > > addons/falcon-bridge/src/test/resources/policy-store.txt 048affe > addons/hbase-bridge/src/test/resources/policy-store.txt 048affe > addons/hive-bridge/src/test/resources/policy-store.txt 048affe > addons/kafka-bridge/pom.xml 52f90d6 > > addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java > da6e7b9 > > addons/kafka-bridge/src/test/java/org/apache/atlas/kafka/bridge/KafkaBridgeTest.java > PRE-CREATION > addons/kafka-bridge/src/test/resources/atlas-application.properties > PRE-CREATION > addons/kafka-bridge/src/test/resources/atlas-log4j.xml PRE-CREATION > addons/kafka-bridge/src/test/resources/users-credentials.properties > PRE-CREATION > addons/sqoop-bridge/src/test/resources/policy-store.txt 048affe > addons/storm-bridge/src/test/resources/policy-store.txt 048affe > > > Diff: https://reviews.apache.org/r/67033/diff/3/ > > > Testing > ------- > > 1) Added unit test > 2) No Integration test for this now, so skipped that. > 3) This patch addresses the exceptions in Kafka bridge module build. > > > Verified in PRE-COMMIT > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/362/console > > > Thanks, > > Ramesh Mani > >