----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67060/#review203230 -----------------------------------------------------------
distro/pom.xml Lines 123 (patched) <https://reviews.apache.org/r/67060/#comment285318> This results in omag-server binaries to be includes in Atlas packaging. Unless the implementation is hardened with sufficient testing, I would strongly recommend to not package this module. - Madhan Neethiraj On May 13, 2018, 8:54 a.m., Nigel Jones wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67060/ > ----------------------------------------------------------- > > (Updated May 13, 2018, 8:54 a.m.) > > > Review request for atlas, David Radley, Graham Wallis, Madhan Neethiraj, and > Mandy Chessell. > > > Repository: atlas > > > Description > ------- > > Added OMAG Server to distribution with an easy to launch jar > (See JIRA for more information) > > > Diffs > ----- > > distro/pom.xml 6431fd86d > distro/src/main/assemblies/omag-server.xml PRE-CREATION > omag-server/README.md PRE-CREATION > omag-server/pom.xml 4c1c98aa3 > > > Diff: https://reviews.apache.org/r/67060/diff/6/ > > > Testing > ------- > > Built atlas > Checked correct files in distribution archive > Checked OMAG server launches with default config > > > Thanks, > > Nigel Jones > >
