> On May 16, 2018, 4:37 p.m., Madhan Neethiraj wrote: > > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java > > Lines 77 (patched) > > <https://reviews.apache.org/r/66949/diff/3/?file=2019359#file2019359line77> > > > > Shouldn't homeId be added to AtlasObjectId as well? Please review and > > update.
I'm not sure - the GUID is still globally unique provides a means to uniquely identify an entity or relationship. The homeId is additional context, but it's not clear to me that it would be required in a reference to an entity or relationship. The purpose of homeId is to enable the enterprise OMRS to determine whether an object originated from (is 'owned' by) Atlas or is something a copy stored in Atlas, of an object that originated in a different repository. The enterprise OMRS uses that information for routing, etc. I am happy to add homeId to AtlasObjectId (and maybe AtlasRelatedObjectId) if you still think it should be there. - Graham ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66949/#review203241 ----------------------------------------------------------- On May 10, 2018, 2:52 p.m., Graham Wallis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66949/ > ----------------------------------------------------------- > > (Updated May 10, 2018, 2:52 p.m.) > > > Review request for atlas, Ashutosh Mestry and Madhan Neethiraj. > > > Repository: atlas > > > Description > ------- > > ATLAS-2523: Changes to accept external GUIDs and manage homeIds > > > Diffs > ----- > > common/src/main/java/org/apache/atlas/repository/Constants.java 3732556ae > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java > 7f36a10f5 > intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java > d04daa5d2 > intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 6c0fdbf36 > repository/src/main/java/org/apache/atlas/query/RegistryBasedLookup.java > 78ab206d3 > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > 7490a15b1 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java > 9fcba6dda > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java > cd00639de > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java > 183a2f6c0 > > > Diff: https://reviews.apache.org/r/66949/diff/3/ > > > Testing > ------- > > Functional testing of these changes to save reference copies of entities and > relationships > > > Thanks, > > Graham Wallis > >
