> On Aug. 17, 2018, 2:35 a.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/repository/impexp/ClusterService.java > > Line 108 (original), 119 (patched) > > <https://reviews.apache.org/r/68270/diff/8-9/?file=2072611#file2072611line125> > > > > if entity doesn't already have the attribute, shouldn't the attribute > > be added in the vertex? > > Ashutosh Mestry wrote: > Wouldn't entity always have all the attributes?
Not necessarily. However, in that case, why even have this 'if'? - Madhan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68270/#review207467 ----------------------------------------------------------- On Aug. 17, 2018, 2:45 a.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68270/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2018, 2:45 a.m.) > > > Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath > Subramanian. > > > Bugs: ATLAS-2814 > https://issues.apache.org/jira/browse/ATLAS-2814 > > > Repository: atlas > > > Description > ------- > > **Approach** > - New model _ReplicationDetails_ store replication timestamp. > - _AuditWriter_ updates appropriate _AtlasCluster_ entity with > _ReplicationDetails_. > > **REST Call** > Endpoint: /admin/expimp/audit > CURL: > curl -X GET -u admin:admin -H "Content-Type: application/json" -H > "Cache-Control: no-cache" > http://localhost:21000/api/atlas/admin/expimp/audit?cluster=cl2 > > > Diffs > ----- > > addons/models/patches/004-base_model_replication_attributes.json > bee37180d6f7fa2f241a0b06685e5a48163ccaa6 > client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java > f73ba2c6e6c9d05e86eb6c17f923a6dda1df5dd9 > intg/src/main/java/org/apache/atlas/model/clusterinfo/AtlasCluster.java > 3ce50e38b3af45521c2c83d0e6c05398747bcf86 > intg/src/main/java/org/apache/atlas/model/impexp/AtlasExportResult.java > 85a606c7d3b2158238b2a6defbb9185883434d78 > intg/src/main/java/org/apache/atlas/model/impexp/AtlasImportResult.java > bfb7637711e08e17fd5f5b16bf121ac541b631a4 > > repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java > 55f70767c8076b8e058190dbf9582d4df047b00a > > repository/src/main/java/org/apache/atlas/repository/impexp/AuditsWriter.java > 6a3fbecda84dc48e0df1359c1b5a248958db0a4c > > repository/src/main/java/org/apache/atlas/repository/impexp/ClusterService.java > fd8e2bfe6bbdb7ae5e66ab67ecdf94e9527d9b09 > > repository/src/main/java/org/apache/atlas/repository/impexp/ExportImportAuditService.java > e90b6b942d359f78ccf59ee955c4667f2033e6c4 > > repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java > b15f828e470eaee972a4ee3f8447f404f813c699 > > repository/src/main/java/org/apache/atlas/repository/impexp/ImportService.java > 98ef389bd1bf8f87d23a06dc231d4d93f06b2231 > > repository/src/main/java/org/apache/atlas/repository/impexp/ImportTransformer.java > 348bcd2c737ed9a37918847744a98be55ea8238d > > repository/src/main/java/org/apache/atlas/repository/ogm/AtlasClusterDTO.java > 424fb88a5ad2d84ac2245848d061892d40a3f50c > repository/src/main/java/org/apache/atlas/repository/ogm/DataAccess.java > b7e943f14084882cd5a3ad22c21168ea098eefcb > > repository/src/main/java/org/apache/atlas/repository/ogm/ExportImportAuditEntryDTO.java > 8d1aebf5c2ad3a030e4140e4d28abbc034ac5919 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java > fcdd379480fa0ce990e0c21b96d7a0529488a1d5 > > repository/src/test/java/org/apache/atlas/repository/impexp/ClusterServiceTest.java > cfd272fb00a970ab0ba28f96b237de6bd5c694e1 > > repository/src/test/java/org/apache/atlas/repository/impexp/ExportImportAuditServiceTest.java > d0188dd93bd66654d3f7337033828701deb3afc9 > > repository/src/test/java/org/apache/atlas/repository/impexp/ExportImportTestBase.java > fcf90d364950d3afa2c18689d8e22616cfcd3c19 > > repository/src/test/java/org/apache/atlas/repository/impexp/ExportIncrementalTest.java > 86ab22294918701270db3ba849f5b0532c1a21a4 > > repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java > dc25e92d7115db31cbd7f99bd1a2cb5f75e766a5 > > repository/src/test/java/org/apache/atlas/repository/impexp/ImportTransformsTest.java > 9b389225a408ba2bd7b06261bcb0f8e447b60532 > > repository/src/test/java/org/apache/atlas/repository/impexp/ReplicationEntityAttributeTest.java > 881368ce2c6803c8cf887a1fc91737c045c5e663 > repository/src/test/resources/json/stocksDB-Entities/replicationAttrs.json > 82826383c37fccd23db1ff56033134bd2bf71ec6 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeDefinition.java > 5561f0b21d98a444c772bcd818a928d16a761a69 > > typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeInfo.java > c24a55f1811095d0ff4f3ea5761c8441f839c033 > webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java > d4e72620b15f69d258e5a2a96521c65a7ef71114 > > webapp/src/test/java/org/apache/atlas/web/resources/AdminExportImportTestIT.java > fc804d2e5a1debd7e728dca1773f91402d41fc26 > webapp/src/test/resources/json/export-incremental.json > 97108411f9e0c177ac13eb0a8ec3bd4475499f89 > webapp/src/test/resources/stocks-base.zip > 40c7f37eefb46a944921f6a74a916191704cb9a3 > > > Diff: https://reviews.apache.org/r/68270/diff/10/ > > > Testing > ------- > > **Unit tests** > New tests added. > Unit tests related to audits now pause for 5 secs before performing asserts. > This should give time for indexes to be created. > > **Pre-commit** > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/595/ > > > Thanks, > > Ashutosh Mestry > >
