Ashutosh – review board has trouble in saving the comments. So here it is:
hdfs_path entity-type includes 'clusterName' attribute. Please update to populate this attribute as well. Thanks, Madhan From: Ashutosh Mestry <nore...@reviews.apache.org> on behalf of Ashutosh Mestry <ames...@hortonworks.com> Reply-To: Ashutosh Mestry <ames...@hortonworks.com> Date: Tuesday, September 11, 2018 at 3:32 PM To: Apoorv Naik <naik.apo...@gmail.com>, Nixon Rodrigues <nixon.rodrig...@freestoneinfotech.com>, Madhan Neethiraj <mad...@apache.org>, Sarath Subramanian <sar...@apache.org> Cc: Ashutosh Mestry <ames...@hortonworks.com>, atlas <d...@atlas.incubator.apache.org> Subject: Review Request 68691: Export Service: Hdfs path entities are created before starting export This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68691/ Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. By Ashutosh Mestry. Bugs: ATLAS-2869<https://issues.apache.org/jira/browse/ATLAS-2869> Repository: atlas Description Approach - HdfsPathCreator class creates hdfs_path entity based on parameters. - ExportService uses the new class. CURL curl -X POST -u admin:admin -H "Content-Type: application/json" -H "Cache-Control: no-cache" -d @../docs/export-options.json http://localhost:21000/api/atlas/admin/export > ../docs/hr.zip export-options.json { "itemsToExport": [ { "typeName": "hdfs_path", "uniqueAttributes": { "path": "/warehouse/hr" }} ], "options": { "fetchType": "full", "matchType": "startsWith", "skipLineage": "true", "replicatedTo": "clx", "changeMarker": 0 } } Testing Unit tests New tests added. Functional tests Verified via UI. Diffs * repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java (aded67caf) * repository/src/main/java/org/apache/atlas/repository/impexp/HdfsPathEntityCreator.java (PRE-CREATION) * repository/src/test/java/org/apache/atlas/repository/impexp/HdfsPathEntityCreatorTest.java (PRE-CREATION) View Diff<https://reviews.apache.org/r/68691/diff/1/>
