-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68771/
-----------------------------------------------------------
(Updated Sept. 19, 2018, 11:33 p.m.)
Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath
Subramanian.
Changes
-------
Updates include:
- Additional options.
- Refactoring for simplicity.
- Added 'all' condition to _AddClassification_.
Bugs: ATLAS-2882
https://issues.apache.org/jira/browse/ATLAS-2882
Repository: atlas
Description (updated)
-------
**Approach**
Described in JIRA.
**CURL**
_transform_
[{\"conditions\":{\"__entity\":\"topLevel\"},
\"action\":{\"__entity\":\"addClassification: replicated\"}}]
_import-options.json_ update top-level entities:
{
"options": {
"transformers": ""[{\"conditions\":{\"__entity\":\"topLevel:\"},
\"action\":{\"__entity\":\"addClassification: replicated\"}}]"",
"replicateFrom": "cl1"
}
}
_import-options.json_ update all entities:
{
"options": {
"transformers": ""[{\"conditions\":{\"__entity\":\"all:\"},
\"action\":{\"__entity\":\"addClassification: replicated\"}}]"",
"replicateFrom": "cl1"
}
}
_import-options.json_ with multiple conditions:
{
"options": {
"transformers": "[{\"conditions\":{\"__entity\":\"all: \"},
\"action\":{\"__entity\":\"addClassification: replicated\"}},
{\"conditions\":{\"hive_db.clusterName\":\"EQUALS:
cl1\"},\"action\":{\"hive_db.clusterName\":\"SET: clx\"}}]",
"replicateFrom": "cl1"
}
}
curl -g -X POST -u admin:admin -H "Content-Type: multipart/form-data" -H
"Cache-Control: no-cache" -F request=@../docs/import-options.json -F
data=@../docs/hr-detailed.zip "http://localhost:21000/api/atlas/admin/import"
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/entitytransform/Action.java ca5f3a8c8
intg/src/main/java/org/apache/atlas/entitytransform/AtlasEntityTransformer.java
c14f2fdde
intg/src/main/java/org/apache/atlas/entitytransform/BaseEntityHandler.java
c1f286933
intg/src/main/java/org/apache/atlas/entitytransform/Condition.java d44f57509
intg/src/main/java/org/apache/atlas/entitytransform/Context.java PRE-CREATION
intg/src/main/java/org/apache/atlas/entitytransform/NeedsContext.java
PRE-CREATION
intg/src/test/java/org/apache/atlas/entitytransform/TransformationHandlerTest.java
69fba1eaf
repository/src/main/java/org/apache/atlas/repository/impexp/ImportService.java
a09385e08
repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java
b556fe9fd
Diff: https://reviews.apache.org/r/68771/diff/2/
Changes: https://reviews.apache.org/r/68771/diff/1-2/
Testing
-------
**Unit tests**
Additional tests.
**Functional tests**
Via CURL calls.
Thanks,
Ashutosh Mestry