----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68815/#review208924 -----------------------------------------------------------
addons/models/0010-base_model.json Lines 125 (patched) <https://reviews.apache.org/r/68815/#comment293194> How are attributes name/displayName/qualifiedName different? An example would be helpful; is the following correct? - name: clx - qualifiedName: Urugway$clx - displayName: clx Also, given 'qualifiedName' is currently used in Referenceable, and AtlasServer is not a sub-type of Referenceable, consider using a different name - like 'fullName'. - Madhan Neethiraj On Sept. 23, 2018, 5:11 a.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68815/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2018, 5:11 a.m.) > > > Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath > Subramanian. > > > Bugs: ATLAS-2886 > https://issues.apache.org/jira/browse/ATLAS-2886 > > > Repository: atlas > > > Description > ------- > > **Approach** > - Continue using existing options from _AtlasExportRequest_ and > _AtlasImportRequest_. > - Pass fully qualified cluster name in the format (data center name)$(cluster > name) > - Support existing format of just cluster name. > - Modify _AuditsWriter_ to parse the new format. > - Use existing _AtlasServer_ to populate _AtlasServer.qualifiedName_ property. > > > **CURL** > > __export-options.json__ > ``` > { > "itemsToExport": [ > { "typeName": "hdfs_path", "uniqueAttributes": { "path": > "hdfs://localhost:8080/warehouse/hr/fulltime" }} > ], > "options": { > "fetchType": "incremental", > "skipLineage": "true", > "replicatedTo": "Urugway$clx", > "changeMarker": 0 > } > } > > ``` > > ``` > curl -X POST -u admin:admin -H "Content-Type: application/json" -H > "Cache-Control: no-cache" -d @../docs/export-options.json > http://localhost:21000/api/atlas/admin/export > ../docs/hr-fulltime.zip > ``` > > > Diffs > ----- > > addons/models/0010-base_model.json dc9e9d641 > intg/src/main/java/org/apache/atlas/model/impexp/AtlasServer.java 67d011022 > > repository/src/main/java/org/apache/atlas/repository/impexp/AuditsWriter.java > 08576fe7d > > repository/src/main/java/org/apache/atlas/repository/ogm/AtlasServerDTO.java > 6343a5d90 > > repository/src/test/java/org/apache/atlas/repository/impexp/ExportImportAuditServiceTest.java > 16fd39dd0 > > repository/src/test/java/org/apache/atlas/repository/impexp/IncrementalExportEntityProviderTest.java > 22ad66fc0 > > repository/src/test/java/org/apache/atlas/repository/impexp/ReplicationEntityAttributeTest.java > 8de736829 > > repository/src/test/resources/json/stocksDB-Entities/export-replicatedTo.json > a69fe9e48 > > repository/src/test/resources/json/stocksDB-Entities/import-replicatedFrom.json > 1ce00ad7e > > > Diff: https://reviews.apache.org/r/68815/diff/1/ > > > Testing > ------- > > **Unit tests** > > Updated existing. > > **Functional tests** > Observe the _AtlasServer_ properties page. > > **Pre-commit Build** > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/682/ > > > Thanks, > > Ashutosh Mestry > >
