----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68363/#review210275 -----------------------------------------------------------
webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java Line 89 (original), 93 (patched) <https://reviews.apache.org/r/68363/#comment294934> Is DEFAULT_PROXY_USERS needed any more? Only users explicitly specified via 'atlas.proxyusers.' configurations should be considered as proxy-users. webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java Lines 193 (patched) <https://reviews.apache.org/r/68363/#comment294933> Move this const definition up, to line #93. Also, this is duplicated in AtlasProxyUsers class; avoid this duplication. webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java Lines 494 (patched) <https://reviews.apache.org/r/68363/#comment294950> does this set the current logged in user as 'doAsUser'? webapp/src/main/java/org/apache/atlas/web/filters/AtlasProxyUsers.java Lines 46 (patched) <https://reviews.apache.org/r/68363/#comment294935> Replace "atlas.proxyuser" with constant defined in line #19. - Madhan Neethiraj On Nov. 2, 2018, 2:33 p.m., Nixon Rodrigues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68363/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2018, 2:33 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, Larry McCay, Madhan > Neethiraj, and Sarath Subramanian. > > > Bugs: ATLAS-2824 > https://issues.apache.org/jira/browse/ATLAS-2824 > > > Repository: atlas > > > Description > ------- > > This patch includes code to support request from knox proxy, where the proxy > is already known and trusted to Atlas via configuration. Atlas intercepts the > incoming requests and if it from knox proxy. Atlas allow the knox's doAs user > to create session in Atlas. > > Configs required:- > > atlas.authentication.allow.trustedproxy :- property allow trusted proxy > support > atlas.proxyuser.knox.hosts :- property to add trusted hosts > atlas.proxyuser.knox.users :- property to add trusted users > atlas.proxyuser.knox.groups :- property to add trusted groups > > > Diffs > ----- > > > webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java > 9a13cea65 > webapp/src/main/java/org/apache/atlas/web/filters/AtlasProxyUsers.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/68363/diff/4/ > > > Testing > ------- > > Tested > > * Atlas UI from Trusted Knox Proxy with Knox SSO loginpage. > * Atlas UI from Knox Proxy with Atlas Login. > * Atlas UI from Knox Proxy with SSO Filter enabled at Atlas. > * Atlas UI with Atlas Login. > * Atlas api from curl with BASIS & Kerberos headers > > > https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/573/console > > Topology Used:- > > > <topology> > <gateway> > ????????<provider> > ????????????<role>federation</role> > ????????????<name>SSOCookieProvider</name> > ????????????<enabled>true</enabled> > ????????????<param> > ????????????????<name>sso.authentication.provider.url</name> > ????????????????<value>{KNOXHOST}/gateway/knoxsso/knoxauth/login.html</value> > ????????????</param> > ????????</provider> > ????????<provider> > ????????????<role>identity-assertion</role> > ????????????<name>Default</name> > ????????????<enabled>true</enabled> > ????????</provider> > </gateway> > <service> > <role>ATLAS</role> > <url>{ATLAS_HOST}:21000/</url> > </service> > <service> > <role>ATLAS-API</role> > <url>{ATLAS_HOST}:21000</url> > </service> > </topology> > > > Thanks, > > Nixon Rodrigues > >
