----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69511/#review211091 -----------------------------------------------------------
open-metadata/README.md Lines 19 (patched) <https://reviews.apache.org/r/69511/#comment295989> I was expecting the instructions on how to configure and run the Atlas connector to be in this readme. open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/eventmapper/AtlasOMRSRepositoryEventMapper.java Lines 64 (patched) <https://reviews.apache.org/r/69511/#comment295974> I am wondering what happens if you run 2 Atlas instances on the same machine - I assume we would need to have the ability to specify different topic names. open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasEntityMapper.java Lines 194 (patched) <https://reviews.apache.org/r/69511/#comment295987> remove? open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasEntityMapper.java Lines 344 (patched) <https://reviews.apache.org/r/69511/#comment295988> remove? open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSMetadataCollection.java Lines 18 (patched) <https://reviews.apache.org/r/69511/#comment295975> License here twice open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSMetadataCollection.java Lines 474 (patched) <https://reviews.apache.org/r/69511/#comment295980> Shouldn't we catch and throw the specific exception types? This pattern is used in all the methods. I am wondering why we need this try catch at all, I wonder if we should remove all these try catches; it seems to be there to just add debug tracing, if we are going to trace shouldn't we be putting out error tracing for the error - or is this done elsewhere? Similar to method processAtlasClassificationDef. open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSMetadataCollection.java Lines 11945 (patched) <https://reviews.apache.org/r/69511/#comment295981> I am not sure what the CTOR is open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSMetadataCollection.java Lines 15188 (patched) <https://reviews.apache.org/r/69511/#comment295977> is this right it looks like it is processing as a Boolean? Most of the other debug steing do not look right in this method. open-metadata/src/main/java/org/apache/atlas/openmetadata/admin/server/spring/OpenMetadataAdminResource.java Lines 429 (patched) <https://reviews.apache.org/r/69511/#comment295982> Should we remove this ? open-metadata/src/main/java/org/apache/atlas/openmetadata/admin/server/spring/OpenMetadataAdminResource.java Lines 454 (patched) <https://reviews.apache.org/r/69511/#comment295983> should we remove this? open-metadata/src/main/java/org/apache/atlas/openmetadata/admin/server/spring/OpenMetadataAdminResource.java Lines 477 (patched) <https://reviews.apache.org/r/69511/#comment295984> remove? open-metadata/src/main/java/org/apache/atlas/openmetadata/admin/server/spring/OpenMetadataAdminResource.java Lines 496 (patched) <https://reviews.apache.org/r/69511/#comment295985> remove? open-metadata/src/main/java/org/apache/atlas/openmetadata/admin/server/spring/OpenMetadataAdminResource.java Lines 516 (patched) <https://reviews.apache.org/r/69511/#comment295986> remove? - David Radley On Dec. 5, 2018, 3:52 p.m., Graham Wallis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69511/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2018, 3:52 p.m.) > > > Review request for atlas. > > > Repository: atlas > > > Description > ------- > > ATLAS-1773: Atlas OMRS conenctor and event mapper > > > Diffs > ----- > > open-metadata/README.md PRE-CREATION > open-metadata/pom.xml PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/eventmapper/AtlasOMRSRepositoryEventMapper.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/eventmapper/AtlasOMRSRepositoryEventMapperProvider.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasAttributeDefMapper.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasAttributeMapper.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasBaseTypeDefMapper.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasClassificationDefMapper.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasEntityDefMapper.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasEntityMapper.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasRelationshipDefMapper.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasRelationshipMapper.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasStoresProxy.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/AtlasStoresProxyImpl.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/Comparator.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/DSLQueryHelper.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/EntityDefMapper.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/FamousFive.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/ISpringBridge.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSErrorCode.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSMetadataCollection.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSRepositoryConnector.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/LocalAtlasOMRSRepositoryConnectorProvider.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/SpringBridge.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TypeDefsByCategory.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TypeNameUtils.java > PRE-CREATION > > open-metadata/src/main/java/org/apache/atlas/openmetadata/admin/server/spring/OpenMetadataAdminResource.java > PRE-CREATION > > open-metadata/src/test/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TestAtlasClassificationDefMapper.java > PRE-CREATION > > open-metadata/src/test/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TestAtlasEntityDefMapper.java > PRE-CREATION > > open-metadata/src/test/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TestAtlasEntityMapper.java > PRE-CREATION > > open-metadata/src/test/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TestAtlasRelationshipDefMapper.java > PRE-CREATION > > open-metadata/src/test/java/org/apache/atlas/openmetadata/adapters/repositoryconnector/TestAtlasRelationshipMapper.java > PRE-CREATION > pom.xml 49fe7de14bf52f9a1de7153eab0484f42e25e37a > webapp/pom.xml e1988c34863053489c3331a994b328adc92347b0 > webapp/src/main/webapp/WEB-INF/openMetadataContext.xml PRE-CREATION > webapp/src/main/webapp/WEB-INF/web.xml > 23dc0637a8b521ab89a16ec8b03895cdaf8bc7d8 > > > Diff: https://reviews.apache.org/r/69511/diff/1/ > > > Testing > ------- > > Full testing with Egeria Compliance Test Suite - passes provided ATLAS-2939 > and ATLAS-2985 patches are present. > > > Thanks, > > Graham Wallis > >
