----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69804/#review212188 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java Line 345 (original), 345 (patched) <https://reviews.apache.org/r/69804/#comment297869> Comments for this method (before this commit) detail the need for traversing all edges i.e. ATLAS-1104. Is that issue not relevant now (perhaps after moving to JanusGraph?)? Please review. - Madhan Neethiraj On Jan. 21, 2019, 11:30 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69804/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2019, 11:30 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Nixon > Rodrigues. > > > Bugs: ATLAS-3034 > https://issues.apache.org/jira/browse/ATLAS-3034 > > > Repository: atlas > > > Description > ------- > > Perf enhancement to avoid unnecessary lookup when creating new relationships > in entityGraphMapper > > > Diffs > ----- > > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > 45bf8dca4 > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasRelationshipStore.java > 44689516e > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2.java > 86cc98cda > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > 98734cc1d > > > Diff: https://reviews.apache.org/r/69804/diff/1/ > > > Testing > ------- > > Precommit run: > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/880/console > > Before patch : Creating hive_table with 5000 columns took ~31 minutes > After patch : Creating hive_table with 5000 columns took ~8.4 minutes > > > Thanks, > > Sarath Subramanian > >
