> On Feb. 8, 2019, 12:31 a.m., Madhan Neethiraj wrote: > > tools/classification-updater/src/main/java/org/apache/atlas/tools/BulkFetchAndUpdate.java > > Lines 427 (patched) > > <https://reviews.apache.org/r/69926/diff/1/?file=2124507#file2124507line427> > > > > Shouldn't line #427 be: > > > > return (String) > > header.getAttribute(getUniqueAttribute(header.getTypeName()); > > > > Currently, this statement returns the name of the uniqueAttribute; and > > not entity attribute value.
Good catch! - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69926/#review212648 ----------------------------------------------------------- On Feb. 8, 2019, 12:01 a.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69926/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2019, 12:01 a.m.) > > > Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-3046 > https://issues.apache.org/jira/browse/ATLAS-3046 > > > Repository: atlas > > > Description > ------- > > Using _EntityType.getUniqueAttribute_ using REST client. > > > Diffs > ----- > > > tools/classification-updater/src/main/java/org/apache/atlas/tools/BulkFetchAndUpdate.java > 1e0b66dfc > > > Diff: https://reviews.apache.org/r/69926/diff/1/ > > > Testing > ------- > > **Functional tests** > - Using user defined entity type. > - Using out of box types. > > > Thanks, > > Ashutosh Mestry > >
