----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70036/#review213037 -----------------------------------------------------------
webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java Lines 701 (patched) <https://reviews.apache.org/r/70036/#comment298898> From https://docs.oracle.com/javase/7/docs/api/java/util/List.html: subList(int fromIndex, int toIndex) Returns a view of the portion of this list between the specified fromIndex, inclusive, and toIndex, exclusive. Since 'toIndex' is exclisive, the code looks correct. Please review and let me know if this is still an issue. - madhan On Feb. 21, 2019, 3:51 p.m., madhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70036/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2019, 3:51 p.m.) > > > Review request for atlas, Ashutosh Mestry, keval bhatt, Nikhil Bonte, Nixon > Rodrigues, and Sarath Subramanian. > > > Bugs: ATLAS-3054 > https://issues.apache.org/jira/browse/ATLAS-3054 > > > Repository: atlas > > > Description > ------- > > updated notification hook consumer to commit creates/updates in batches, > specified via configuration atlas.notification.consumer.commit.batch.size > (default size 50). > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStream.java > 75a7e6110 > > webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java > f829260e8 > > webapp/src/main/java/org/apache/atlas/notification/preprocessor/PreprocessorContext.java > 7b4229bd0 > > > Diff: https://reviews.apache.org/r/70036/diff/1/ > > > Testing > ------- > > - pre-commit tests run: > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/930/ > > > Thanks, > > madhan > >
