----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70064/#review213248 -----------------------------------------------------------
Ship it! Ship It! - Nixon Rodrigues On Feb. 27, 2019, 6:04 a.m., madhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70064/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2019, 6:04 a.m.) > > > Review request for atlas, Ashutosh Mestry, keval bhatt, Nikhil Bonte, Nixon > Rodrigues, and Sarath Subramanian. > > > Bugs: ATLAS-3058 > https://issues.apache.org/jira/browse/ATLAS-3058 > > > Repository: atlas > > > Description > ------- > > Saved-search entity references its parent entity via relationship-attribute > userProfile. During validation of saved-search entity, the referenced > user-profile entity is not found in the store, since the user-profile entity > is created only when first search is saved for this user. Updated to use > internal-guid to resolve entity referenced by userProfile > relationship-attribute (instead of resolving by unique-attribute). > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/ogm/profiles/AtlasSavedSearchDTO.java > 1a24e67d0 > > repository/src/main/java/org/apache/atlas/repository/ogm/profiles/AtlasUserProfileDTO.java > 982d646b3 > > > Diff: https://reviews.apache.org/r/70064/diff/1/ > > > Testing > ------- > > - verified that saving/update/delete of favorite-searches succeed > - pre-commit tests run: > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/934/ > > > Thanks, > > madhan > >
