sarathkumarsubramanian commented on a change in pull request #37: 
ATLAS-2933:Empty array attributes are returned as null instead of an empty list
URL: https://github.com/apache/atlas/pull/37#discussion_r269261518
 
 

 ##########
 File path: 
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
 ##########
 @@ -740,7 +741,9 @@ private Object mapVertexToAttribute(AtlasVertex 
entityVertex, AtlasAttribute att
         Map<String, AtlasObjectId> ret        = null;
         Map                        softRefVal = 
entityVertex.getProperty(attribute.getVertexPropertyName(), Map.class);
 
-        if (MapUtils.isNotEmpty(softRefVal)) {
+        if (softRefVal == null || MapUtils.isEmpty(softRefVal)) {
 
 Review comment:
   MapUtils.isEmpty(softRefVal) checks for null and empty map, consider 
recoming softRefVal == null from if condition

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to