----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70359/#review214401 -----------------------------------------------------------
Fix it, then Ship it! intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java Lines 775 (patched) <https://reviews.apache.org/r/70359/#comment300609> normalizeRelationshipAttributeValuesForUpdate() is a duplicate of normalizeRelationshipAttributeValues() except for line #787. consider refactoring. intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java Line 782 (original), 819 (patched) <https://reviews.apache.org/r/70359/#comment300610> duplicate method similar to #797, only #831 is different. consider refactoring - Sarath Subramanian On April 4, 2019, 5:52 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70359/ > ----------------------------------------------------------- > > (Updated April 4, 2019, 5:52 p.m.) > > > Review request for atlas, Ashutosh Mestry, keval bhatt, Kapildeo Nayak, > Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian. > > > Bugs: ATLAS-3054 > https://issues.apache.org/jira/browse/ATLAS-3054 > > > Repository: atlas > > > Description > ------- > > To enable batch-processing of entities in large notification message, > ownedRef attributes are removed. Sometimes ownedRef entities may not have > attribute that points to container entity (for example hive_column.table > attribute). This patch addressed this case by adding the missing attribute > that points to the contianer entity. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java 6147eee91 > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 1ce776ee3 > intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java > 585d176ca > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java fb24df0f3 > intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 079a8fc1f > intg/src/test/java/org/apache/atlas/type/TestAtlasStructType.java a37dd46b1 > > repository/src/main/java/org/apache/atlas/repository/converters/AtlasStructFormatConverter.java > 173fcee65 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStream.java > d12b03610 > > webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java > 48355c941 > > webapp/src/main/java/org/apache/atlas/notification/preprocessor/EntityPreprocessor.java > 085e746b4 > > webapp/src/main/java/org/apache/atlas/notification/preprocessor/HivePreprocessor.java > 0b93658fd > > webapp/src/main/java/org/apache/atlas/notification/preprocessor/PreprocessorContext.java > c85c1b86a > > webapp/src/main/java/org/apache/atlas/notification/preprocessor/RdbmsPreprocessor.java > adc19836a > > > Diff: https://reviews.apache.org/r/70359/diff/5/ > > > Testing > ------- > > - precommit test run: > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1011/ > > > Thanks, > > Madhan Neethiraj > >
