> On April 17, 2019, 9:08 p.m., Sarath Subramanian wrote: > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java > > Lines 144 (patched) > > <https://reviews.apache.org/r/70462/diff/5/?file=2139793#file2139793line145> > > > > change DEBUG to WARN, also you are missing a {} in the debug message. > > consider moving the logic to get hostname in getHostName() method
Changing message level to warning. - Aadarsh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70462/#review214732 ----------------------------------------------------------- On April 16, 2019, 6:06 p.m., Aadarsh Jajodia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70462/ > ----------------------------------------------------------- > > (Updated April 16, 2019, 6:06 p.m.) > > > Review request for atlas, Ashutosh Mestry, Sridhar K, Le Ma, Madhan > Neethiraj, and Sarath Subramanian. > > > Bugs: ATLAS-3133 > https://issues.apache.org/jira/browse/ATLAS-3133 > > > Repository: atlas > > > Description > ------- > > Adding support for Process Executions in Atlas > > > Diffs > ----- > > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/AtlasHiveHookContext.java > 44c6437fe8e9bf93d823157ca0ff7b36cec9bb87 > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java > ee02285df67aa27f45f1116fd0c2015b779f9311 > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java > 31346d0954140cd8bda690dc9079e0913f7b9d7d > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateHiveProcess.java > d61f1d74e3238e0a7474de67c0400c108d8919ea > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateTable.java > 674a89f6e4852dc30c29c5681854ec3ba8611f35 > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataTypes.java > 94010d0cb1a7a5c48b71f6d77c5e1a8f5cfcf013 > addons/hive-bridge/src/test/java/org/apache/atlas/hive/HiveITBase.java > 002b90839f78dc843b5aca56042c3decd299bed8 > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java > 142e35561fff42f7672c5b5136af1173049580b3 > addons/models/0000-Area0/0010-base_model.json > 8b41ee89f3a7288bb4cdad3df6887242b40b68d2 > addons/models/1000-Hadoop/1030-hive_model.json > e96443382a587411d1207d6e1157ea65350cbdba > webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java > 6fcea9ed43f7e3d93742c7de4bc4db4386ecdb2d > > > Diff: https://reviews.apache.org/r/70462/diff/5/ > > > Testing > ------- > > We want to add support for Process Executions in Atlas. With the help of > process executions attributes specific to each execution(like startTime, > endTime, queryText) will be captured in the execution object. With the > current model of Atlas this is lost since each execution overrides the > previous one. To solve this problem. We are creating 2 new entity definitions > and one relations definition. We create an entity definition called a process > execution and another one called hive process execution. The hive process > execution has all the attributes which are specific to each execution. We > also create a relationship defintion between a hive process and a hive > process execution as a many to one relation. The lineage does not get > affected in this since the inputs and outputs are still attached to the hive > process. Hive Process can now be thought of as a grouping of multiple > executions. There is no lineage shown for a hive process execution. The > criteria for grouping is based on the qualif iedName of a Hive Process. As long as the qualified Name of a hive process remains the same, each execution gets mapped to the same hive process. > > > Thanks, > > Aadarsh Jajodia > >
