----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70516/#review214859 -----------------------------------------------------------
client/common/src/main/java/org/apache/atlas/security/SecureClientUtils.java Lines 161 (patched) <https://reviews.apache.org/r/70516/#comment301119> Encapsulate within inner class. webapp/src/main/java/org/apache/atlas/examples/QuickStart.java Line 80 (original), 80 (patched) <https://reviews.apache.org/r/70516/#comment301116> redundant webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java Line 154 (original), 154 (patched) <https://reviews.apache.org/r/70516/#comment301117> redundant webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java Line 173 (original), 178 (patched) <https://reviews.apache.org/r/70516/#comment301118> Remove - Ashutosh Mestry On April 24, 2019, 10:07 a.m., Nixon Rodrigues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70516/ > ----------------------------------------------------------- > > (Updated April 24, 2019, 10:07 a.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath > Subramanian. > > > Bugs: ATLAS-3129 > https://issues.apache.org/jira/browse/ATLAS-3129 > > > Repository: atlas > > > Description > ------- > > AtlasBaseClient uses Hadoop's SSLFactory to create the > ReloadingX509TrustManager > > https://github.com/apache/atlas/blob/b919d3d0964efbe1eda40724545d5fa506100a02/client/common/src/main/java/org/apache/atlas/security/SecureClientUtils.java#L143 > > currently, there is no way to stop/destroy method of the > ReloadingX509TrustManager, this creates "Truststore reloader thread" leak in > hiveserver2 if the user is running any HOOK/UDF which uses the AtlasClient. > > Solution:- Refactoring of code and added destroy method to destroy SSLFactory > instance. > > Usage of AtlasClient : AtlasClient will be used same way just need to call > new method "close()" of AtlasClientV2 in finally block of Hook Client code > which creating/invoking AtlasClientV2 methods. > > > Diffs > ----- > > > addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseBridge.java > 17d617d19 > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java > 21ceda200 > > addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java > 214dd2512 > client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java cb7340fb6 > > client/common/src/main/java/org/apache/atlas/security/SecureClientUtils.java > aeae300a6 > webapp/src/main/java/org/apache/atlas/examples/QuickStart.java c043b65eb > webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java 6fcea9ed4 > > > Diff: https://reviews.apache.org/r/70516/diff/3/ > > > Testing > ------- > > Testing Import-Hive, Quickstart Script from Atlas in Kerberos and Simple mode. > > > Thanks, > > Nixon Rodrigues > >
