----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70574/#review215008 -----------------------------------------------------------
Fix it, then Ship it! intg/src/main/java/org/apache/atlas/entitytransform/HiveTableEntityHandler.java Lines 52 (patched) <https://reviews.apache.org/r/70574/#comment301303> Consider marking tableNameFromQualifiedNameDifferent and tableNameFromQualifiedName as final. intg/src/main/java/org/apache/atlas/entitytransform/HiveTableEntityHandler.java Lines 68 (patched) <https://reviews.apache.org/r/70574/#comment301301> Please handle cases where 'databaseSeparatorIdx == -1' and 'clusterSeparatorIdx == -1'. intg/src/main/java/org/apache/atlas/entitytransform/HiveTableEntityHandler.java Line 66 (original), 71 (patched) <https://reviews.apache.org/r/70574/#comment301302> initialize tableNameFromQualifiedNameDifferent and tableNameFromQualifiedName? - Madhan Neethiraj On May 2, 2019, 5:36 a.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70574/ > ----------------------------------------------------------- > > (Updated May 2, 2019, 5:36 a.m.) > > > Review request for atlas, Kapildeo Nayak, Madhan Neethiraj, Nikhil Bonte, and > Sarath Subramanian. > > > Bugs: ATLAS-3182 > https://issues.apache.org/jira/browse/ATLAS-3182 > > > Repository: atlas > > > Description > ------- > > Simple string manipulation. > > **Transforms** > > import-options.json > ``` > { > "options": { > "transformers": "[{\"conditions\":{\"hive_db.clusterName\":\"EQUALS: > mycluster0\"},\"action\":{\"hive_db.clusterName\":\"SET: > mycluster1\"}},{\"conditions\":{\"hive_db.name\":\"EQUALS: > test_partition_bootstrap\"},\"action\":{\"hive_db.name\":\"SET: > test_partition_bootstrap_target\"}}]" > } > } > ``` > **Import Zip** > (Attached) > > **CURL** > > curl -X POST -u admin:admin123 -H "Content-Type: multipart/form-data" -H > "Cache-Control: no-cache" -F data=@./test_partition_bootstrap.zip -F > request=@./import-options.json http://localhost:21000/api/atlas/admin/import > > > Diffs > ----- > > > intg/src/main/java/org/apache/atlas/entitytransform/HiveTableEntityHandler.java > 9eb44d782 > > intg/src/test/java/org/apache/atlas/entitytransform/TransformationHandlerTest.java > d6b0ede2b > intg/src/test/resources/json/entity1.json PRE-CREATION > intg/src/test/resources/json/transform1.json PRE-CREATION > > > Diff: https://reviews.apache.org/r/70574/diff/2/ > > > Testing > ------- > > **Unit tests** > Additional test. > > **Functional test** > Existing Import flow using test data. > > > File Attachments > ---------------- > > Zip to Import > > https://reviews.apache.org/media/uploaded/files/2019/04/30/44469b66-884c-4bde-8200-e41306a19b3b__test_partition_bootstrap.zip > > > Thanks, > > Ashutosh Mestry > >
