> On 5 17, 2019, 4:28 오전, Jungtaek Lim wrote: > > addons/models/1000-Hadoop/1100-spark_model.json > > Lines 337 (patched) > > <https://reviews.apache.org/r/70600/diff/2/?file=2145506#file2145506line337> > > > > I think you've asked this before, sorry to miss this. This represents > > "elapsed time" so type `long` is correct. Maybe we would want to rename > > attribute to `elapsedTimeNs` or so.
Showing nanoseconds would't help reading - milliseconds, or human readable string. We can go with milliseconds first. Btw, spark listener interface has its name as `durationNs` - `durationMs` would be better. ``` def onSuccess(funcName: String, qe: QueryExecution, durationNs: Long): Unit ``` - Jungtaek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70600/#review215314 ----------------------------------------------------------- On 5 16, 2019, 11:54 오후, Aadarsh Jajodia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70600/ > ----------------------------------------------------------- > > (Updated 5 16, 2019, 11:54 오후) > > > Review request for atlas, Ankur Gupta, Arun Mahadevan, Ashutosh Mestry, > Jungtaek Lim, Sridhar K, Le Ma, Madhan Neethiraj, and Sarath Subramanian. > > > Repository: atlas > > > Description > ------- > > This is an initial mode file for the SPARK models. Please refer to the file > added here. This file is a GET call on typeDefs on a cluster which had SAC > enabled and SAC has created the models. The SAC version used was > https://github.com/hortonworks/spark-atlas-connector/tree/SAC-CDP-1.0-dev > > > Diffs > ----- > > addons/models/1000-Hadoop/1100-spark_model.json PRE-CREATION > > > Diff: https://reviews.apache.org/r/70600/diff/3/ > > > Testing > ------- > > > File Attachments > ---------------- > > SAC Models > > https://reviews.apache.org/media/uploaded/files/2019/05/07/e31827b2-04c5-4fab-b5b7-4271398831e4__spark_sac_api_model_definition.txt > > > Thanks, > > Aadarsh Jajodia > >
