----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70708/#review215511 -----------------------------------------------------------
Fix it, then Ship it! Overall looks good to me. Some minor comments. addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/BaseImpalaEvent.java Lines 561-562 (patched) <https://reviews.apache.org/r/70708/#comment302243> Maybe use long for both? addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/CreateImpalaProcess.java Lines 120 (patched) <https://reviews.apache.org/r/70708/#comment302242> Change to processExecution != null addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageToolIT.java Lines 201-205 (patched) <https://reviews.apache.org/r/70708/#comment302244> Can we also add a unit test which produces more than one execution? - Aadarsh Jajodia On May 23, 2019, 9:11 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70708/ > ----------------------------------------------------------- > > (Updated May 23, 2019, 9:11 p.m.) > > > Review request for atlas, Aadarsh Jajodia, Madhan Neethiraj, and Sarath > Subramanian. > > > Repository: atlas > > > Description > ------- > > ATLAS-3133 adds a new feature to track metadata for different executions of > the same process in Atlas. Need to add this in Impala integration > > > Diffs > ----- > > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/AtlasImpalaHookContext.java > 88faace > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/ImpalaLineageHook.java > 232a569 > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/BaseImpalaEvent.java > 63c5f87 > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/CreateImpalaProcess.java > 0dc520c > > addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageITBase.java > 0138d88 > > addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageToolIT.java > 033a518 > > addons/impala-bridge/src/test/java/org/apache/atlas/impala/hook/ImpalaLineageHookIT.java > 86801e3 > > > Diff: https://reviews.apache.org/r/70708/diff/1/ > > > Testing > ------- > > Integration tests > > > Thanks, > > Na Li > >
