----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70745/#review215576 -----------------------------------------------------------
Optional request: Is it possible to extend _AtlasAuthenticationKerberosFilterTest_ to test for this case? webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java Line 304 (original), 305 (patched) <https://reviews.apache.org/r/70745/#comment302300> Can you please move all the property strings to private static final String? - Ashutosh Mestry On May 29, 2019, 1:30 p.m., Nixon Rodrigues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70745/ > ----------------------------------------------------------- > > (Updated May 29, 2019, 1:30 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nikhil Bonte, > and Sarath Subramanian. > > > Bugs: ATLAS-3243 > https://issues.apache.org/jira/browse/ATLAS-3243 > > > Repository: atlas > > > Description > ------- > > This patch provides changes required to support UI access Atlas via Trusted > Knox proxy, there some changes required in AtlasAuthenticationFilter. > > > Diffs > ----- > > > webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java > b6ed545e6 > > > Diff: https://reviews.apache.org/r/70745/diff/1/ > > > Testing > ------- > > Tested Atlas different scenario's > > 1) curl call with kerberos. > 2) curl Simple basic heaeder > 3) Atlas login page. > 4) curl with trusted proxy > 4) Atlas UI with Trusted Proxy with Knox shiroprovider. > 5) Atlas UI with Trusted proxy with KnoxSSOCoookieProvider. > > > Thanks, > > Nixon Rodrigues > >