[ 
https://issues.apache.org/jira/browse/ATLAS-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854799#comment-16854799
 ] 

Diego Marino Monetti commented on ATLAS-3180:
---------------------------------------------

[~mad...@apache.org] - I realized that Atlas-3219 has a better implementation 
of getServiceTypePredicate because it excludes the ClassificationType:
{quote}     private static Predicate getServiceTypePredicate (final String 
serviceType) {
     return new Predicate () {
             *private boolean isClassificationType (Object o) {*
                 *return or instanceof AtlasClassificationType;*
             *}*

             private boolean isAtlasType (Object o) {
                 return or instanceof AtlasType;
             }

      @Override
        public boolean evaluate (Object o) {
                 return o! = null && isAtlasType (o) *&&! isClassificationType 
(o)*
                 && Objects.equals (((AtlasType) o) .getServiceType (), 
serviceType);
      }
    
     };
   }
{quote}
It is not very relevant so I would not change the rc3 of 1.2 but it could be 
the case to make the patch for 2.0 and 3.0. Evaluate yourself

>  New Bulk retrieval API with servicetype parameter
> --------------------------------------------------
>
>                 Key: ATLAS-3180
>                 URL: https://issues.apache.org/jira/browse/ATLAS-3180
>             Project: Atlas
>          Issue Type: Bug
>          Components:  atlas-core
>    Affects Versions: 1.2.0, 2.0.0
>         Environment: All OS
>            Reporter: Diego Marino Monetti
>            Assignee: Diego Marino Monetti
>            Priority: Major
>             Fix For: 1.2.0, 2.1.0, 3.0.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The Bulk api retrieval returns all defined types or filtered types by name, 
> type and supertype. With the addition of the service type among the basic 
> attributes of the Atlas types it is necessary to have the possibility to 
> search also for service type through a http request of the type:
> {quote}[http://host:port/api/atlas/V2/types/typedefs?serviceType|http://hostport/]
>  = requested-service-type
> {quote}
> to search only for types related to a specific service type.
>  This pull request solves this problem
> l[https://github.com/apache/atlas/pull/49]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to