----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70789/ -----------------------------------------------------------
(Updated June 7, 2019, 10:28 p.m.) Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, keval bhatt, Sridhar K, Le Ma, Nikhil Bonte, Nixon Rodrigues, Saqeeb Shaikh, and Sarath Subramanian. Changes ------- updated to address review comments. Bugs: ATLAS-3262 https://issues.apache.org/jira/browse/ATLAS-3262 Repository: atlas Description ------- - skipped full-text index computation & population when free-text is enabled - added FreeTextRequestHandlerPatch to create /freetext request handler in Solr - fixed free-text search handling of typeName filter Diffs (updated) ----- graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java edab08cc0 graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java 18e6976a4 graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphSolrIndexClient.java a55fc3689 graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java 0d5ae4f84 intg/src/main/java/org/apache/atlas/ApplicationProperties.java 6d0153f7d intg/src/main/java/org/apache/atlas/listener/ChangedTypeDefs.java 0636677ae repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java c929d9a62 repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java e4a315fce repository/src/main/java/org/apache/atlas/discovery/FreeTextSearchProcessor.java b1a84c742 repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 50edb9faf repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 2e09beda0 repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 56655a845 repository/src/main/java/org/apache/atlas/repository/graph/IndexChangeListener.java 9cde947aa repository/src/main/java/org/apache/atlas/repository/graph/SolrIndexHelper.java 20a517ff1 repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java 259f24674 repository/src/main/java/org/apache/atlas/repository/patches/FreeTextRequestHandlerPatch.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java 035b02ce4 repository/src/main/java/org/apache/atlas/util/AtlasRepositoryConfiguration.java 1d296057b Diff: https://reviews.apache.org/r/70789/diff/4/ Changes: https://reviews.apache.org/r/70789/diff/3-4/ Testing ------- - verified that free-text handler is created by the patch for the first time this enhancement is applied in an existing env - verified that the free-text search handles typeName filter correctly - pre-commit tests run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1176/ Thanks, Madhan Neethiraj