> On June 21, 2019, 7:08 p.m., Le Ma wrote: > > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java > > Lines 674 (patched) > > <https://reviews.apache.org/r/70913/diff/1/?file=2151500#file2151500line680> > > > > Just a thoungt, is it possible to change "options" from <String, > > String> to <String, Object>, then you can avoid all these string > > manipulation things by organizing them under a sub-map: > > options : { > > "DynAttributes" : { > > "QualifiedName" : ... > > } > > }
There is already code that reads in the options as a <String, String> that I don't want to mess with, so that's why I'm keep the dynamicAttributes as a <String, String>. - Merryle ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70913/#review216062 ----------------------------------------------------------- On June 20, 2019, 11:52 p.m., Merryle Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70913/ > ----------------------------------------------------------- > > (Updated June 20, 2019, 11:52 p.m.) > > > Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, > Madhan Neethiraj, and Sarath Subramanian. > > > Repository: atlas > > > Description > ------- > > ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes > > > Diffs > ----- > > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateHiveProcess.java > 7791fb4c656a354065ad8f28ae8618c6e07d8ed4 > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateTable.java > aedb1552be14bf92d3464f44a5d89e8106104aeb > addons/models/1000-Hadoop/1030-hive_model.json > 8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad > intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java > 4171942026efbc021d707fdc047e4d647208d021 > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java > d9ae9e36773146fad652a1e28fc8822bae5c8557 > intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java > 98071b297efef8596206842923d85d20b267cc10 > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java > 254eee4c9d18ab87a8862ce479fc2274227c7c29 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > 64f5503fe70ebd494cabecd04da78494b6b827ac > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java > 02638c3ba5c429380ec9f098c143b49314604159 > > > Diff: https://reviews.apache.org/r/70913/diff/1/ > > > Testing > ------- > > Planning to add unit tests > > > Thanks, > > Merryle Wang > >
