----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70913/#review216083 -----------------------------------------------------------
addons/models/1000-Hadoop/1030-hive_model.json Lines 550 (patched) <https://reviews.apache.org/r/70913/#comment303065> why add a new type - 'hive_ddl' ? intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java Lines 166 (patched) <https://reviews.apache.org/r/70913/#comment303066> both dynAttributes and dynEvalTriggerAttributes are class variables, why pass as arguments? - populateDynFlagsInfo() intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java Lines 680 (patched) <https://reviews.apache.org/r/70913/#comment303067> this delim ('|') is no longer valid, please review and remove. intg/src/main/java/org/apache/atlas/type/AtlasStructType.java Line 771 (original), 774 (patched) <https://reviews.apache.org/r/70913/#comment303068> revert formatting change if unintended. - Sarath Subramanian On June 21, 2019, 5:40 p.m., Merryle Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70913/ > ----------------------------------------------------------- > > (Updated June 21, 2019, 5:40 p.m.) > > > Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, > Madhan Neethiraj, and Sarath Subramanian. > > > Repository: atlas > > > Description > ------- > > ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes > > > Diffs > ----- > > addons/models/1000-Hadoop/1030-hive_model.json > 8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java > d9ae9e36773146fad652a1e28fc8822bae5c8557 > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java > 254eee4c9d18ab87a8862ce479fc2274227c7c29 > intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java > 3c53c02b48747515217c9327c98209a48ee84237 > > > Diff: https://reviews.apache.org/r/70913/diff/2/ > > > Testing > ------- > > Planning to add unit tests > > > Thanks, > > Merryle Wang > >
