> On July 2, 2019, 3:50 p.m., Ashutosh Mestry wrote: > > This an edge case: When temporary tables are created, their qualifiedName > > gets suffixed with GUID, how will this scheme handle that? > > Aadarsh Jajodia wrote: > Hi Ashutosh, Thats a good point you mentioned. Right now we don't have a > way in the templates to refer to a system attribute(we might need this as you > mentioned for a temp table). We can take that up later.
See this: AtlasHiveHookContext public String getQualifiedName(Table table) { String tableName = table.getTableName(); if (table.isTemporary()) { if (SessionState.get() != null && SessionState.get().getSessionId() != null) { tableName = tableName + TEMP_TABLE_PREFIX + SessionState.get().getSessionId(); } else { tableName = tableName + TEMP_TABLE_PREFIX + RandomStringUtils.random(10); } } return (table.getDbName() + QNAME_SEP_ENTITY_NAME + tableName + QNAME_SEP_CLUSTER_NAME).toLowerCase() + getClusterName(); } - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70913/#review216308 ----------------------------------------------------------- On July 1, 2019, 6:10 p.m., Merryle Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70913/ > ----------------------------------------------------------- > > (Updated July 1, 2019, 6:10 p.m.) > > > Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, > Madhan Neethiraj, and Sarath Subramanian. > > > Repository: atlas > > > Description > ------- > > ATLAS-3286: Populated dynamic attribute flags for AtlasAttributes > > > Diffs > ----- > > addons/models/1000-Hadoop/1030-hive_model.json > 8901aa4aa86fb2802a9e9b1e65c2ff8aad8855ad > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java > d9ae9e36773146fad652a1e28fc8822bae5c8557 > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java > 254eee4c9d18ab87a8862ce479fc2274227c7c29 > intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java > 3c53c02b48747515217c9327c98209a48ee84237 > > > Diff: https://reviews.apache.org/r/70913/diff/7/ > > > Testing > ------- > > Added unit test > > > Thanks, > > Merryle Wang > >