----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71058/#review216525 -----------------------------------------------------------
Ship it! Ship It! - Ashutosh Mestry On July 11, 2019, 2:14 p.m., Nixon Rodrigues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71058/ > ----------------------------------------------------------- > > (Updated July 11, 2019, 2:14 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath > Subramanian. > > > Bugs: ATLAS-3329 > https://issues.apache.org/jira/browse/ATLAS-3329 > > > Repository: atlas > > > Description > ------- > > There are instance in code where User name is retrieved from > httpServletRequest.getRemoteUser() via Servlets.getUserName method. > If request are coming from proxy then doAs user is impersonate as valid Atlas > user, getting user name from remote will cause confusion. > > So it make sense to update the usage of Servlets.getUserName to > AtlasAuthorizationUtils.getCurrentUserName(). > > > Diffs > ----- > > webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java > 2716873dd > webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java f70938e7b > > > Diff: https://reviews.apache.org/r/71058/diff/1/ > > > Testing > ------- > > performed Sanity test by creating Saved search and perform import operation. > > > Thanks, > > Nixon Rodrigues > >
