----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71202/#review216972 -----------------------------------------------------------
Please check if JIRA referenced in this review, ATLAS-3220, is the right one. repository/src/main/java/org/apache/atlas/repository/impexp/ImportTypeDefProcessor.java Lines 74 (patched) <https://reviews.apache.org/r/71202/#comment304197> why set end1/end2 to null? For other types, this method sets guid to null. - Madhan Neethiraj On July 30, 2019, 4:56 p.m., Ashutosh Mestry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71202/ > ----------------------------------------------------------- > > (Updated July 30, 2019, 4:56 p.m.) > > > Review request for atlas, Nikhil Bonte, Nixon Rodrigues, and Sarath > Subramanian. > > > Bugs: ATLAS-3220 > https://issues.apache.org/jira/browse/ATLAS-3220 > > > Repository: atlas > > > Description > ------- > > **Approach** > - Updated _ImportTypeDefProcessor_ to process _AtlasRelationhip_. > > **Pre-commit** > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1319/ > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/impexp/ImportTypeDefProcessor.java > c21793733 > > repository/src/main/java/org/apache/atlas/repository/impexp/TypeAttributeDifference.java > e3d86c862 > > > Diff: https://reviews.apache.org/r/71202/diff/1/ > > > Testing > ------- > > **Unit tests** > Existing tests. > > **Functional tests** > Export and import tests with steps from bug. > > > Thanks, > > Ashutosh Mestry > >
