----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71215/#review217002 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On July 31, 2019, 9:10 a.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71215/ > ----------------------------------------------------------- > > (Updated July 31, 2019, 9:10 a.m.) > > > Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Le Ma, Madhan > Neethiraj, and Nixon Rodrigues. > > > Bugs: ATLAS-3353 > https://issues.apache.org/jira/browse/ATLAS-3353 > > > Repository: atlas > > > Description > ------- > > For the below commands, HMS Hook does not capture the replaced column as > deleted entity. > > create table table_with_dropped_cols_1 (id int,name string,dob date) > alter table table_with_dropped_cols_1 replace columns (id int,name > string,address string) > > > Diffs > ----- > > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveMetastoreHookImpl.java > 251fddd74 > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateTable.java > aedb1552b > > > Diff: https://reviews.apache.org/r/71215/diff/1/ > > > Testing > ------- > > Validated manually using beeline. > > Precommit: > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1320/console > > > Thanks, > > Sarath Subramanian > >
