----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71127/#review217093 -----------------------------------------------------------
Fix it, then Ship it! intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java Lines 1032 (patched) <https://reviews.apache.org/r/71127/#comment304352> Moving 'if not visited' check to entry of this method can help avoid this check in topologicalSort(). private void visitAttribute(...) { if (!visited.contains(attribute)) { visited.add(attribute); for (AtlasAttribute neighbor : adj.get(attribute)) { visitAttribute(neighbor, visited, order, adj); } order.add(attribute); } } - Madhan Neethiraj On Aug. 5, 2019, 10:19 p.m., Merryle Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71127/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2019, 10:19 p.m.) > > > Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, > Madhan Neethiraj, and Sarath Subramanian. > > > Repository: atlas > > > Description > ------- > > ATLAS-3343: Ordering of dynAttr evaluation > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java > 23eaa0a2e88fd348d2347314170726ebb5cb4393 > intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java > c114bdf7888519cdd396fc8501bbcd92b00ef0bb > > > Diff: https://reviews.apache.org/r/71127/diff/5/ > > > Testing > ------- > > Created dummy dynamic attributes to test the correct ordering. > > > Thanks, > > Merryle Wang > >
