----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71108/#review217096 -----------------------------------------------------------
intg/src/main/java/org/apache/atlas/type/DependentToken.java Lines 51-72 (patched) <https://reviews.apache.org/r/71108/#comment304355> Instead of having these null checks can we use Optional type in Java? We can avoid making those null checks. repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityFinder.java Lines 30 (patched) <https://reviews.apache.org/r/71108/#comment304354> Can we add more comments in this class for every method to understand the sequence of which method is called for which scenario? Like for example the getByGuid add a comment saying trying to fetch the object from the entity stream and so on for the other methods. Also can we rename getByGuid to getFromEntityStream? since actually we are just getting the object from the entityStream in that method. repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java Lines 887-893 (patched) <https://reviews.apache.org/r/71108/#comment304353> Do we need to do this everytime? We should be only doing this for an update which involves dynamicAttribute or a dependent one. - Aadarsh Jajodia On July 30, 2019, 11:54 p.m., Merryle Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71108/ > ----------------------------------------------------------- > > (Updated July 30, 2019, 11:54 p.m.) > > > Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, > Madhan Neethiraj, and Sarath Subramanian. > > > Repository: atlas > > > Description > ------- > > Dynamic Attributes for the current entity are generated and set. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java > 23eaa0a2e88fd348d2347314170726ebb5cb4393 > intg/src/main/java/org/apache/atlas/type/AttributeToken.java > 658cf865ec1fe4eb326930024c4f189f59df0e7e > intg/src/main/java/org/apache/atlas/type/ConstantToken.java > 5ba54ae6333440b633e3b6a1175b384676004cf9 > intg/src/main/java/org/apache/atlas/type/DependentToken.java > c1c7d3df70118dd127b74d4ece65a47185258bc4 > intg/src/main/java/org/apache/atlas/type/TemplateToken.java > fffbc2ae3ff72144a2779437c600f42d684cf548 > intg/src/main/java/org/apache/atlas/utils/EntityFinder.java PRE-CREATION > intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java > c114bdf7888519cdd396fc8501bbcd92b00ef0bb > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java > 01b8d196b354cf089fe4b040e396761c9a19a7eb > > repository/src/main/java/org/apache/atlas/repository/store/graph/EntityGraphDiscoveryContext.java > 2221ac4f421fbdbb2d8d39889863223568a3ae70 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityFinder.java > PRE-CREATION > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java > 84bb2a363358d213611d321c01cb5f14078ae09d > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java > 983d4fa7250aec40f0b83d586a5a71a063bbed62 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStream.java > c823b20079ab9ff61fc0ff9b59ccb6b301c0664d > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStreamForImport.java > 6bf962e8b206b0bc320f3268e269e9292de08b84 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityImportStream.java > cf7ac28f9d6f0d86a2c92a984a331e818a4f5f9b > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityStream.java > 41b834204b077e7a866198fead736298524787fa > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IDBasedEntityResolver.java > fe76b3a8943180f8a4332b6363ddc782da321aa4 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/InMemoryMapEntityStream.java > e1ade0709779bfd9acc5532434bdab12c6236591 > > repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java > a4edaf086ebc162cf6343e9ea439185f495691e6 > webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java > e5b9563d6005372e8acd11633542af59bca1ef78 > > webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java > 940c639cba02763887843ed14b8240bfc7569631 > > webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerTest.java > ece46a42b77d5fb5db2b9c1b042cc5327747c1e3 > > > Diff: https://reviews.apache.org/r/71108/diff/3/ > > > Testing > ------- > > Tested with creates and updates, dynamicAttributes are calculated correctly. > Ran mvn install for both the intg and repository packages. > > > Thanks, > > Merryle Wang > >