----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71295/ -----------------------------------------------------------
Review request for atlas, Sridhar K, Madhan Neethiraj, and Sarath Subramanian. Bugs: ATLAS-3370 https://issues.apache.org/jira/browse/ATLAS-3370 Repository: atlas Description ------- **Background** New patch for aggregates introduces Asset.__s_name, etc. This exposed flaw in current DSL query engine where it was using AtlasEntityType.qualifiedAttributeName instead of getVertexPropertyName. It did not matter so far since both APIs returned same values. **Approach** - Modified GremlinQueryComposer, to use output of getVertexPropertyName when adding Gremlin clauses. - Added new method to org.query.atlas.query.Lookup to fetch vertex property name. - Additional error handling. - Additional refactoring. - Additional unit tests. Diffs ----- addons/models/0000-Area0/0010-base_model.json 1c807116d graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java 08923f8da graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java 613a714ff graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java b6889c873 graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AbstractGraphDatabaseTest.java f72b41214 intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 8c1dbd77c intg/src/main/java/org/apache/atlas/type/AtlasStructType.java e7ec3d862 intg/src/main/java/org/apache/atlas/v1/model/typedef/AttributeDefinition.java d9a3a8134 repository/src/main/java/org/apache/atlas/query/GremlinClauseList.java 71179772a repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 17c837bb3 repository/src/main/java/org/apache/atlas/query/IdentifierHelper.java e74c0f5a0 repository/src/main/java/org/apache/atlas/query/Lookup.java ec95f5d89 repository/src/main/java/org/apache/atlas/query/RegistryBasedLookup.java e67eeafa6 repository/src/main/java/org/apache/atlas/query/SelectClauseComposer.java 999fe5c8b repository/src/main/java/org/apache/atlas/repository/converters/TypeConverterUtil.java a248de605 repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 8d8e4ad92 repository/src/main/java/org/apache/atlas/repository/patches/UniqueAttributePatch.java bd5f525fa repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java 8d7dbfbb2 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasStructDefStoreV2.java b93faf0c1 repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 568667054 Diff: https://reviews.apache.org/r/71295/diff/1/ Testing ------- **Unit tests** DSLQueriesTest: 246 (multiplied by 2). GremlinQueryComposerTest: 39 tests. **Integration tests** Existing set. Thanks, Ashutosh Mestry