> On sep 5, 2019, 8:15 p.m., Ashutosh Mestry wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > > Line 907 (original), 907 (patched) > > <https://reviews.apache.org/r/71278/diff/1/?file=2160649#file2160649line907> > > > > Are you OK with this warning being under debug log level?
thanks for reviewing. I dont follow you comment? We noticed performance (10s per entity for ingestion) issues but we had to turn on debugging to find that we were triggering an unoptimized code path. Having this at warn would have saved us a lot of time and maybe others. INFO might work to. happy to change it to that if that is what you require. - Bolke ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71278/#review217597 ----------------------------------------------------------- On aug 21, 2019, 7:42 p.m., Bolke de Bruin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71278/ > ----------------------------------------------------------- > > (Updated aug 21, 2019, 7:42 p.m.) > > > Review request for atlas, Nixon Rodrigues and Saqeeb Shaikh. > > > Bugs: https://issues.apache.org/jira/browse/ATLAS-3368 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/ATLAS-3368 > > > Repository: atlas > > > Description > ------- > > If an entity is created that has a definition with a reference to a > non built in type, it will trigger a legacy code path in > EntityGraphMapper. > This path can take excessive amounts of time (>5s per commit), but > operators > can be caught unaware as the log message for this is at debug > level and explain the portential issue. > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > f9010fefb > > > Diff: https://reviews.apache.org/r/71278/diff/1/ > > > Testing > ------- > > - reviewed patch logging to warn > > > Thanks, > > Bolke de Bruin > >
