----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71406/#review217610 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On Sept. 6, 2019, 10:10 a.m., Nikhil Bonte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71406/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2019, 10:10 a.m.) > > > Review request for atlas, madhan, Nixon Rodrigues, and Sarath Subramanian. > > > Bugs: ATLAS-3387 > https://issues.apache.org/jira/browse/ATLAS-3387 > > > Repository: atlas > > > Description > ------- > > Consider X-FORWARDED-FOR header for getting end user IP address when > connected with proxy > > > Diffs > ----- > > > authorization/src/main/java/org/apache/atlas/authorize/AtlasAccessRequest.java > b031f4c3e > > authorization/src/main/java/org/apache/atlas/authorize/AtlasAdminAccessRequest.java > 1782b3272 > > authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizationUtils.java > ac2f52525 > > authorization/src/main/java/org/apache/atlas/authorize/AtlasEntityAccessRequest.java > 07ff678ed > > authorization/src/main/java/org/apache/atlas/authorize/AtlasRelationshipAccessRequest.java > d2da03c1a > > authorization/src/main/java/org/apache/atlas/authorize/AtlasSearchResultScrubRequest.java > c908b28a7 > > authorization/src/main/java/org/apache/atlas/authorize/AtlasTypeAccessRequest.java > af38425fb > server-api/src/main/java/org/apache/atlas/RequestContext.java d518609d3 > webapp/src/main/java/org/apache/atlas/web/filters/AuditFilter.java > 54f7330da > > > Diff: https://reviews.apache.org/r/71406/diff/7/ > > > Testing > ------- > > Tested with simple authorizer. Need to test after ranger end changes. > > > Thanks, > > Nikhil Bonte > >
