[
https://issues.apache.org/jira/browse/ATLAS-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16943132#comment-16943132
]
Madhan Neethiraj commented on ATLAS-3433:
-----------------------------------------
Couple of comments on this patch:
# Avoid double negatives where easily possible. I think the following can be
avoided:
{noformat}
if (!CollectionUtils.isNotEmpty(entityTypes)) {
{noformat}
# As much as possible, have a single exit point for a method. It makes reading
a code *a lot easier*; and also makes it easy/simple to add entry/exit log
statements.
> Basic Search: Results include Internal Entities
> -----------------------------------------------
>
> Key: ATLAS-3433
> URL: https://issues.apache.org/jira/browse/ATLAS-3433
> Project: Atlas
> Issue Type: Bug
> Components: atlas-core
> Affects Versions: trunk
> Reporter: Ashutosh Mestry
> Assignee: Ashutosh Mestry
> Priority: Critical
> Fix For: trunk
>
> Attachments:
> ATLAS-3433-Internal-entities-were-inadvertently-index.patch
>
>
> *Background*
> Internal entities are designed for book keeping and other logistics. They are
> not the data that is stored by the user.
> *Steps to Duplicate*
> _Pre-requisites_: Populate Atlas with some data. Search for _hdfs_path_ type
> entities. Create a Saved Search say _'HDFS: Web Logs'_.
> _Steps to Duplicate_:
> * Search for _web_logs_.
> _Expected outcome_: _hdfs_path_ entities that have _web_logs_ in their name
> should be displayed.
> _Actual outcome_: Saved search _HDFS: Web Logs_ is part of the results. This
> entity is of type ___AtlasUserSavedSearch_.
> _Additional information_: Other internal entities are also displayed with
> search results.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
