-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71623/#review218243
-----------------------------------------------------------


Fix it, then Ship it!





webapp/src/main/java/org/apache/atlas/web/servlets/ErrorServlet.java
Lines 30 (patched)
<https://reviews.apache.org/r/71623/#comment305884>

    Rename class: "ErrorServlet" => "AtlasErrorServlet"



webapp/src/main/java/org/apache/atlas/web/servlets/ErrorServlet.java
Lines 37 (patched)
<https://reviews.apache.org/r/71623/#comment305886>

    update contentType from constant:
    
    public final static String TEXT_HTML = "text/html";



webapp/src/main/java/org/apache/atlas/web/servlets/LoginServlet.java
Lines 29 (patched)
<https://reviews.apache.org/r/71623/#comment305883>

    +1 rename to AtlasLoginServlet



webapp/src/main/java/org/apache/atlas/web/servlets/LoginServlet.java
Lines 36 (patched)
<https://reviews.apache.org/r/71623/#comment305885>

    update contentType from constant:
    
    public final static String TEXT_HTML = "text/html";



webapp/src/main/webapp/WEB-INF/web.xml
Lines 39 (patched)
<https://reviews.apache.org/r/71623/#comment305881>

    nit: remove additional new line



webapp/src/main/webapp/WEB-INF/web.xml
Lines 60 (patched)
<https://reviews.apache.org/r/71623/#comment305882>

    nit: remove additional new line


- Sarath Subramanian


On Oct. 16, 2019, 5:49 a.m., Mandar Ambawane wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71623/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2019, 5:49 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3472
>     https://issues.apache.org/jira/browse/ATLAS-3472
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This patch uses Servlets instead of JSP files to render login and error page.
> 
> 
> Diffs
> -----
> 
>   webapp/src/main/java/org/apache/atlas/web/servlets/ErrorServlet.java 
> PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/servlets/LoginServlet.java 
> PRE-CREATION 
>   webapp/src/main/resources/spring-security.xml 1295244 
>   webapp/src/main/webapp/WEB-INF/web.xml 23dc063 
>   webapp/src/main/webapp/error.html.template PRE-CREATION 
>   webapp/src/main/webapp/error.jsp 29ef640 
>   webapp/src/main/webapp/login.html.template PRE-CREATION 
>   webapp/src/main/webapp/login.jsp 70ec06d 
> 
> 
> Diff: https://reviews.apache.org/r/71623/diff/1/
> 
> 
> Testing
> -------
> 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1475/console
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>

Reply via email to