> On Oct. 23, 2019, 10:20 p.m., Karthik Manamcheri wrote: > > addons/models/4000-MachineLearning/4010-ml_model.json > > Line 328 (original), 328 (patched) > > <https://reviews.apache.org/r/71619/diff/10-11/?file=2170014#file2170014line347> > > > > Why do we need this relationship? We can already trace the relationship > > through lineage? > > > > Model Project -> Train Process -> Model Build > > > > Same goes for the deployment. I don't think we need the relationship > > definition. Do we? > > > > Model Build -> Deploy Process -> Model Deployment
That is what Atlas team preferred. It does no harm, and allow relationship graph to show. - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/#review218374 ----------------------------------------------------------- On Oct. 23, 2019, 9:22 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71619/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2019, 9:22 p.m.) > > > Review request for atlas, Austin Nobis, Ashutosh Mestry, Karthik Manamcheri, > Sridhar K, Madhan Neethiraj, and Sarath Subramanian. > > > Bugs: atlas-3464 > https://issues.apache.org/jira/browse/atlas-3464 > > > Repository: atlas > > > Description > ------- > > Define entities used for Machine Learning Governance > > > Diffs > ----- > > addons/models/4000-MachineLearning/4010-ml_model.json PRE-CREATION > > > Diff: https://reviews.apache.org/r/71619/diff/11/ > > > Testing > ------- > > verified it is valid json file > > > Thanks, > > Na Li > >
